Re: [PATCH v2 06/24] x86: Always inline context_tracking_guest_enter()

Peter Zijlstra
2021-08-25T13:41:01Z

On Fri, Aug 20, 2021 at 04:34:40PM -0700, Josh Poimboeuf wrote:
> On Fri, Aug 20, 2021 at 04:22:07PM -0700, Josh Poimboeuf wrote:
> > On Thu, Jun 24, 2021 at 11:41:05AM +0200, Peter Zijlstra wrote:
> > > Yes, it really did out-of-line this....
> > >
> > > vmlinux.o: warning: objtool: vmx_vcpu_enter_exit()+0x31: call to context_tracking_guest_enter() leaves .noinstr.text section
> > >
> > > 000000000019f660 <context_tracking_guest_enter>:
> > > 19f660: e8 00 00 00 00 callq 19f665 <context_tracking_guest_enter+0x5> 19f661: R_X86_64_PLT32 __sanitizer_cov_trace_pc-0x4
> > > 19f665: 31 c0 xor %eax,%eax
> > > 19f667: c3 retq
> > >
> > > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> >
> > Ha. I'm guessing this was from CONFIG_DEBUG_SECTION_MISMATCH, which is
> > only good for triggering a lot of these useless __always_inline patches.
> >
> > I have a patch somewhere to get rid of it.
>
> Found it.

Even with your patch applied, x86_64-allyesconfig still gives me the
above. In fact, I had to re-instate 4 of the 6 __always_inline patches,
so I've kept them all for now.