From: Peter Zijlstra <peterz@infradead.org>
To: Michel Lespinasse <michel@lespinasse.org>
Cc: Li RongQing <lirongqing@baidu.com>,
dbueso@suse.de, mingo@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rbtree: stop iteration early in rb_find_first
Date: Wed, 25 Aug 2021 15:21:46 +0200 [thread overview]
Message-ID: <YSZD6suya8fR/2uY@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20210825115859.GB4645@lespinasse.org>
On Wed, Aug 25, 2021 at 04:58:59AM -0700, Michel Lespinasse wrote:
> > NAK. This looked slightly wrong before, and is more wrong after.
> Actually, my explanation is wrong too :) but so is the code.
> A failing example would searching 10 in the following tree
>
>
> 10
> /
> 5
> \
> 10
>
> The search would stop after visiting node 5, and miss the leaf which
> is the expected node to be returned.
Just to clarify; the current code *does* work here. The proposed patch
breaks it.
next prev parent reply other threads:[~2021-08-25 13:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 9:59 [PATCH] rbtree: stop iteration early in rb_find_first Li RongQing
2021-08-25 11:39 ` Peter Zijlstra
2021-08-25 11:53 ` Michel Lespinasse
2021-08-25 11:58 ` Michel Lespinasse
2021-08-25 12:31 ` Peter Zijlstra
2021-08-25 13:21 ` Peter Zijlstra [this message]
2021-08-25 16:08 ` 答复: " Li,Rongqing
[not found] ` <90ea3457ddc7485fbc8db5f7ca5b07ab@baidu.com>
2021-08-25 17:18 ` Peter Zijlstra
2021-08-25 18:26 ` 答复: " Li,Rongqing
2021-08-25 19:20 ` Peter Zijlstra
2021-08-26 5:03 ` 答复: " Li,Rongqing
2021-08-25 12:29 ` Peter Zijlstra
2021-08-25 12:32 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSZD6suya8fR/2uY@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=dbueso@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=michel@lespinasse.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox