From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCB4AC432BE for ; Wed, 25 Aug 2021 17:59:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE41560F35 for ; Wed, 25 Aug 2021 17:59:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235089AbhHYSAJ (ORCPT ); Wed, 25 Aug 2021 14:00:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230112AbhHYSAI (ORCPT ); Wed, 25 Aug 2021 14:00:08 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 718E6C061757 for ; Wed, 25 Aug 2021 10:59:22 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id fz10so373103pjb.0 for ; Wed, 25 Aug 2021 10:59:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pABGAmR7jsnbAFg+kdSfi8m+nL0fOQgbOWkA56++kO8=; b=Yi5vdPb2dNIZhdtUXom1jAQNDEKLkpIC16r/bpEol95mYCxR8NHcbYIOhVEUOc0/K1 Axj09rhFcBCD4Dqsl0LuAFmAQ6Y7k7uKq7sUNEq8MDRkjuwEBCw+iUDoB5Mmmp9srV4g /pT7jUpWRWK6/pleo7LhM+nh11LXyXH3wKkqE20DVugplAHNM7dQUTnmOh4kVtALc118 C+VLoMKiPcNJXoR+0fFOzrjxGY4U0yR6+sqgNP8Sqk8RUYKraIKaan5cDZQArKhpdnBJ TVuqAZhR6WwimPWKN7AXKd/GqEo8506xsrggaRc32v1zqylBTOW4yPpTzqLTSFqqeAZt 8axw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pABGAmR7jsnbAFg+kdSfi8m+nL0fOQgbOWkA56++kO8=; b=rOri//w9W72o29q4p4iSiDNy+xgnOYI5GcAT680b42vyRyGemMinMo/7G7iyjnZeeR va4nRSd8cjg72J+8W9eM6c4FDWuxKt1gqGeT4NYwSWSoFgXVJ6eSTo7ntxQhG1EDrLCf oCCjpT37jh+PMgEvVcPqYK9OlnuXBSO+wgcGm1uN9rKe+qgVy1ffoefW4Hyn0RWj55+3 nnqdm5IZ0kJervjvudiA1q0wHhvw1UTELIDRjwwKw1RF0Szj2Br80bxf9qV4J9gNnyH2 XQgceENZWbBEbeAFjuzmY+hu/ySq4buRt2/Hpre7fEDlosHk476GjB5beEH3SrldE+KK LUiQ== X-Gm-Message-State: AOAM531nVyQyKrgQaeZjjLvQp7F00XyJGvutBzRld9O7oy38osFUIDBh CjTR0wRz8NaLs3GySurC+yzlvA== X-Google-Smtp-Source: ABdhPJxcO9mzExRWn0q9Z7VP9IVEQJ9iWCOeQRY0pgkynO+vHIb5PFgctevVD6XoIHyteP4SuDgq0w== X-Received: by 2002:a17:902:7892:b0:133:a1a4:5917 with SMTP id q18-20020a170902789200b00133a1a45917mr17321952pll.17.1629914361705; Wed, 25 Aug 2021 10:59:21 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id q21sm624602pgk.71.2021.08.25.10.59.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Aug 2021 10:59:21 -0700 (PDT) Date: Wed, 25 Aug 2021 17:59:17 +0000 From: Sean Christopherson To: CGEL Cc: Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, linux-kernel@vger.kernel.org, Jing Yangyang , Zeal Robot Subject: Re: [PATCH linux-next] x86:mmu: fix boolreturn.cocci warnings Message-ID: References: <20210824071052.61304-1-deng.changcheng@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210824071052.61304-1-deng.changcheng@zte.com.cn> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "KVM: x86/mmu" in the shortlog please. On Tue, Aug 24, 2021, CGEL wrote: > From: Jing Yangyang > > ./arch/x86/kvm/mmu/mmu.c:1501: 9-10:WARNING:return of 0/1 in > function 'kvm_set_pte_rmapp' with return type bool > ./arch/x86/kvm/mmu/mmu.c:1642:10-11:WARNING:return of 0/1 in > function 'kvm_test_age_rmapp' with return type bool Huh, I could have sworn this was fixed, but obviously not. > Return statements in functions returning bool should use true/false > instead of 1/0. > > Generated by: scripts/coccinelle/misc/boolreturn.cocci > > Reported-by: Zeal Robot > Signed-off-by: Jing Yangyang > --- > arch/x86/kvm/mmu/mmu.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c > index c5232a0..78025e0 100644 > --- a/arch/x86/kvm/mmu/mmu.c > +++ b/arch/x86/kvm/mmu/mmu.c > @@ -1498,7 +1498,7 @@ static bool kvm_set_pte_rmapp(struct kvm *kvm, struct kvm_rmap_head *rmap_head, > > if (need_flush && kvm_available_flush_tlb_with_range()) { > kvm_flush_remote_tlbs_with_address(kvm, gfn, 1); > - return 0; > + return false; Please also fix need_flush in this function, e.g. diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c index 4853c033e6ce..0a275d988c7d 100644 --- a/arch/x86/kvm/mmu/mmu.c +++ b/arch/x86/kvm/mmu/mmu.c @@ -1456,7 +1456,7 @@ static bool kvm_set_pte_rmapp(struct kvm *kvm, struct kvm_rmap_head *rmap_head, { u64 *sptep; struct rmap_iterator iter; - int need_flush = 0; + bool need_flush = false; u64 new_spte; kvm_pfn_t new_pfn; @@ -1468,7 +1468,7 @@ static bool kvm_set_pte_rmapp(struct kvm *kvm, struct kvm_rmap_head *rmap_head, rmap_printk("spte %p %llx gfn %llx (%d)\n", sptep, *sptep, gfn, level); - need_flush = 1; + need_flush = true; if (pte_write(pte)) { pte_list_remove(kvm, rmap_head, sptep); > } > > return need_flush; > @@ -1639,8 +1639,8 @@ static bool kvm_test_age_rmapp(struct kvm *kvm, struct kvm_rmap_head *rmap_head, > > for_each_rmap_spte(rmap_head, &iter, sptep) > if (is_accessed_spte(*sptep)) > - return 1; > - return 0; > + return true; > + return false; > } > > #define RMAP_RECYCLE_THRESHOLD 1000 > -- > 1.8.3.1 > >