From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bryan Brattlof <hello@bryanbrattlof.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] staging: rtl8723bs: remove sdio_write_mem()
Date: Thu, 26 Aug 2021 12:03:56 +0200 [thread overview]
Message-ID: <YSdnDBH7Er7nLr+d@kroah.com> (raw)
In-Reply-To: <20210821235456.2502681-1-hello@bryanbrattlof.com>
On Sat, Aug 21, 2021 at 11:55:05PM +0000, Bryan Brattlof wrote:
> The sdio_write_mem() function is unused in the driver. We can remove it.
>
How do we know it is unused?
Please remove the pointer as well, at the same time, so that we can
obviously see that it is unused (or not).
Same for the other patches in this series.
Also, when you resend this, please use git send-email properly, so that
the patches are threaded so our tools can pick them up easier. This
series was not threaded for some odd reason.
thanks,
greg k-h
prev parent reply other threads:[~2021-08-26 10:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-21 23:55 [PATCH 1/6] staging: rtl8723bs: remove sdio_write_mem() Bryan Brattlof
2021-08-21 23:55 ` [PATCH 5/6] staging: rtl8723bs: remove unused definitions from rtw_io.h Bryan Brattlof
2021-08-26 10:03 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSdnDBH7Er7nLr+d@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hello@bryanbrattlof.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox