Re: [PATCH v2 6/6] workqueue, kasan: avoid alloc_pages() when recording stack

Marco Elver
2021-09-13T17:58:55Z

On Mon, 13 Sept 2021 at 19:03, Tejun Heo <tj@kernel.org> wrote:
>
> On Mon, Sep 13, 2021 at 01:26:09PM +0200, Marco Elver wrote:
> > While there is an increased risk of failing to insert the stack trace,
> > this is typically unlikely, especially if the same insertion had already
> > succeeded previously (stack depot hit). For frequent calls from the same
> > location, it therefore becomes extremely unlikely that
> > kasan_record_aux_stack_noalloc() fails.
> >
> > Link: https://lkml.kernel.org/r/20210902200134.25603-1-skhan@linuxfoundation.org
> > Reported-by: Shuah Khan <skhan@linuxfoundation.org>
> > Signed-off-by: Marco Elver <elver@google.com>
> > Tested-by: Shuah Khan <skhan@linuxfoundation.org>
> > Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>
> Acked-by: Tejun Heo <tj@kernel.org>

Thanks!

> Please feel free to route with the rest of series or if you want me to take
> these through the wq tree, please let me know.

Usually KASAN & stackdepot patches go via the -mm tree. I hope the
1-line change to workqueue won't conflict with other changes pending
in the wq tree. Unless you or Andrew tells us otherwise, I assume
these will at some point appear in -mm.

Thanks,
-- Marco

> Thanks.
>
> --
> tejun