Re: [PATCH 0/8] staging: media: zoran: fusion in one module

Hans Verkuil
2021-09-06T11:04:01Z

Hi Corentin,

I finally had the opportunity to test the staging zoran driver.

I found several issues when running v4l2-compliance -s (I posted a patch
for that), but more seriously is the fact that trying to capture MJPG
at resolutions 384x288 or less just hangs my PC. It works OK with 768x576.

I discovered this when running 'v4l2-compliance -s -a -f'.

BTW, why isn't the initial format equal to MJPG 768x576?
I would expect that for these boards that should be the default format.

Another issue is that the TODO should mention that for video output there
should be a second video device node. And that's really something that
has to be done before the zoran driver can be moved out of staging.

It shouldn't be that hard to implement, I think.

Right now it is impossible to run the compliance test for the output, since
it doesn't even see it as an output.

Regards,

Hans

On 03/09/2021 21:15, Corentin Labbe wrote:
> Hello
>
> The main change of this serie is to fusion all zoran related modules in
> one.
> This fixes the load order problem when everything is built-in.
>
> Regards
>
> Corentin Labbe (8):
> staging: media: zoran: move module parameter checks to zoran_probe
> staging: media: zoran: use module_pci_driver
> staging: media: zoran: rename debug module parameter
> staging: media: zoran: add debugfs
> staging: media: zoran: videocode: remove procfs
> staging: media: zoran: fusion all modules
> staging: media: zoran: remove vidmem
> staging: media: zoran: move videodev alloc
>
> drivers/staging/media/zoran/Kconfig | 24 +-
> drivers/staging/media/zoran/Makefile | 8 +-
> drivers/staging/media/zoran/videocodec.c | 60 +----
> drivers/staging/media/zoran/videocodec.h | 5 +
> drivers/staging/media/zoran/zoran.h | 7 +-
> drivers/staging/media/zoran/zoran_card.c | 259 +++++++++++++--------
> drivers/staging/media/zoran/zoran_driver.c | 5 +-
> drivers/staging/media/zoran/zr36016.c | 23 +-
> drivers/staging/media/zoran/zr36016.h | 2 +
> drivers/staging/media/zoran/zr36050.c | 20 +-
> drivers/staging/media/zoran/zr36050.h | 2 +
> drivers/staging/media/zoran/zr36060.c | 20 +-
> drivers/staging/media/zoran/zr36060.h | 2 +
> 13 files changed, 229 insertions(+), 208 deletions(-)
>