From: Phillip Potter <phil@philpotter.co.uk>
To: Colin King <colin.king@canonical.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: remove redundant variable hoffset
Date: Tue, 7 Sep 2021 23:10:02 +0100 [thread overview]
Message-ID: <YTfjOtrlaZscXVTm@equinox> (raw)
In-Reply-To: <20210907085302.10672-1-colin.king@canonical.com>
On Tue, Sep 07, 2021 at 09:53:02AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable hoffset is being assigned values but it is never being
> used. The variable is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/staging/r8188eu/hal/rtl8188e_hal_init.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
> index 14758361960c..7c12ca548c47 100644
> --- a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
> +++ b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
> @@ -1143,7 +1143,7 @@ static u16 hal_EfuseGetCurrentSize_8188e(struct adapter *pAdapter, bool bPseudoT
> {
> int bContinual = true;
> u16 efuse_addr = 0;
> - u8 hoffset = 0, hworden = 0;
> + u8 hworden = 0;
> u8 efuse_data, word_cnts = 0;
>
> if (bPseudoTest)
> @@ -1156,18 +1156,15 @@ static u16 hal_EfuseGetCurrentSize_8188e(struct adapter *pAdapter, bool bPseudoT
> AVAILABLE_EFUSE_ADDR(efuse_addr)) {
> if (efuse_data != 0xFF) {
> if ((efuse_data & 0x1F) == 0x0F) { /* extended header */
> - hoffset = efuse_data;
> efuse_addr++;
> efuse_OneByteRead(pAdapter, efuse_addr, &efuse_data, bPseudoTest);
> if ((efuse_data & 0x0F) == 0x0F) {
> efuse_addr++;
> continue;
> } else {
> - hoffset = ((hoffset & 0xE0) >> 5) | ((efuse_data & 0xF0) >> 1);
> hworden = efuse_data & 0x0F;
> }
> } else {
> - hoffset = (efuse_data >> 4) & 0x0F;
> hworden = efuse_data & 0x0F;
> }
> word_cnts = Efuse_CalculateWordCnts(hworden);
> --
> 2.32.0
>
Many thanks Colin, looks good to me.
Acked-by: Phillip Potter <phil@philpotter.co.uk>
Regards,
Phil
prev parent reply other threads:[~2021-09-07 22:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 8:53 [PATCH] staging: r8188eu: remove redundant variable hoffset Colin King
2021-09-07 22:10 ` Phillip Potter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTfjOtrlaZscXVTm@equinox \
--to=phil@philpotter.co.uk \
--cc=Larry.Finger@lwfinger.net \
--cc=colin.king@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox