From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Lang Yu <lang.yu@amd.com>
Cc: Joe Perches <joe@perches.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sysfs: Remove page boundary align limitation on sysfs_emit and sysfs_emit_at
Date: Wed, 8 Sep 2021 14:32:06 +0200 [thread overview]
Message-ID: <YTitRjOZtWPTyRHd@kroah.com> (raw)
In-Reply-To: <20210908120723.3920701-1-lang.yu@amd.com>
On Wed, Sep 08, 2021 at 08:07:23PM +0800, Lang Yu wrote:
> The key purpose of sysfs_emit and sysfs_emit_at is to
> ensure that no overrun is done. Make them more equivalent
> with scnprintf.
That's not the only purpose.
So why are you changing this?
What in-kernel users are being tripped up by this, shouldn't we fix them
instead?
Remember, sysfs files are "one value per file", so why are the boundries
not properly set here?
thanks,
greg k-h
next prev parent reply other threads:[~2021-09-08 12:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 12:07 [PATCH] sysfs: Remove page boundary align limitation on sysfs_emit and sysfs_emit_at Lang Yu
2021-09-08 12:32 ` Greg Kroah-Hartman [this message]
2021-09-08 12:52 ` Yu, Lang
2021-09-08 13:04 ` Greg Kroah-Hartman
2021-09-08 13:21 ` Yu, Lang
2021-09-08 13:49 ` Greg Kroah-Hartman
2021-09-08 15:33 ` Yu, Lang
2021-09-09 5:19 ` Greg Kroah-Hartman
2021-09-09 5:31 ` Yu, Lang
2021-09-09 6:05 ` Greg Kroah-Hartman
2021-09-09 5:05 ` Joe Perches
2021-09-09 5:27 ` Yu, Lang
2021-09-09 5:34 ` Greg Kroah-Hartman
2021-09-09 5:59 ` Yu, Lang
2021-09-09 6:07 ` Greg Kroah-Hartman
2021-09-09 5:44 ` Joe Perches
2021-09-09 5:52 ` Yu, Lang
2021-09-09 6:07 ` Greg Kroah-Hartman
2021-09-09 6:22 ` Yu, Lang
2021-09-09 6:35 ` Greg Kroah-Hartman
2021-09-09 7:48 ` Yu, Lang
2021-09-09 7:59 ` Greg Kroah-Hartman
2021-09-09 8:48 ` Yu, Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTitRjOZtWPTyRHd@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=lang.yu@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox