Re: [PATCH 3/3] arm64: dts: qcom: pm8350c: Add pwm support

skakit
2021-09-08T09:15:23Z

On 2021-09-08 09:04, Stephen Boyd wrote:
> Quoting satya priya (2021-09-06 03:41:07)
>> Add pwm support for PM8350C pmic.
>>
>> Signed-off-by: satya priya <skakit@codeaurora.org>
>> ---
>> arch/arm64/boot/dts/qcom/pm8350c.dtsi | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/pm8350c.dtsi
>> b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
>> index e1b75ae..ecdae55 100644
>> --- a/arch/arm64/boot/dts/qcom/pm8350c.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
>> @@ -29,6 +29,12 @@
>> interrupt-controller;
>> #interrupt-cells = <2>;
>> };
>> +
>> + pm8350c_pwm4: pwm {
>> + compatible = "qcom,pm8350c-pwm";
>
> Shouldn't there be a reg property?
>

The bindings do not specify reg property. I think it is because we are
adding the base address in struct "pm8350c_pwm_data".

>> + #pwm-cells = <2>;
>> + status = "okay";
>> + };
>> };
>> };
>>
>> --
>> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
>> member
>> of Code Aurora Forum, hosted by The Linux Foundation
>>