From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82654C433F5 for ; Thu, 9 Sep 2021 07:38:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6979761108 for ; Thu, 9 Sep 2021 07:38:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352743AbhIIHj1 (ORCPT ); Thu, 9 Sep 2021 03:39:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:39434 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352714AbhIIHjU (ORCPT ); Thu, 9 Sep 2021 03:39:20 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8905761101; Thu, 9 Sep 2021 07:38:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631173091; bh=eCY1ICwIr1dBP9cTT2himiHoX0vnoGsm8u9kDNkM4Zc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yF2h3qhybkHF2QQymnXZqxTmnjJQmpSi57xKTBeTF7jqbLTOGTtZmnlS6DDuo/zC7 xiK/eQIlABu4XQsAngI172f4xBLdUlkZJXWa+Z84smDl0nm4BhVxkrtgg8VYjq7PJ4 5PB8xZz//bBTWK8JQ6XVFMEfHmdxWC5CFNwE6sHY= Date: Thu, 9 Sep 2021 08:38:30 +0200 From: Greg Kroah-Hartman To: Neal Liu Cc: Tao Ren , Alan Stern , Tony Prisk , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , BMC-SW Subject: Re: [PATCH v2] usb: ehci: handshake CMD_RUN instead of STS_HALT Message-ID: References: <20210901035041.10810-1-neal_liu@aspeedtech.com> <20210909054531.GA10391@taoren-ubuntu-R90MNF91> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 09, 2021 at 06:23:10AM +0000, Neal Liu wrote: > > > Hi Neal, > > > > On Wed, Sep 01, 2021 at 08:07:53AM +0200, Greg Kroah-Hartman wrote: > > > On Wed, Sep 01, 2021 at 11:50:41AM +0800, neal_liu wrote: > > > > Retitle. > > > > > > > > For Aspeed, HCHalted status depends on not only Run/Stop but also > > > > ASS/PSS status. > > > > Handshake CMD_RUN on startup instead. > > > > > > > > Signed-off-by: neal_liu > > > > --- > > > > drivers/usb/host/ehci-hcd.c | 11 ++++++++++- > > > > drivers/usb/host/ehci-platform.c | 6 ++++++ > > > > drivers/usb/host/ehci.h | 1 + > > > > 3 files changed, 17 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/usb/host/ehci-hcd.c > > > > b/drivers/usb/host/ehci-hcd.c index 10b0365f3439..01c022e46aa2 > > > > 100644 > > > > --- a/drivers/usb/host/ehci-hcd.c > > > > +++ b/drivers/usb/host/ehci-hcd.c > > > > @@ -634,7 +634,16 @@ static int ehci_run (struct usb_hcd *hcd) > > > > /* Wait until HC become operational */ > > > > ehci_readl(ehci, &ehci->regs->command); /* unblock posted writes > > */ > > > > msleep(5); > > > > - rc = ehci_handshake(ehci, &ehci->regs->status, STS_HALT, 0, 100 * 1000); > > > > + > > > > + /* For Aspeed, STS_HALT also depends on ASS/PSS status. > > > > + * Skip this check on startup. > > > > + */ > > > > + if (ehci->is_aspeed) > > > > + rc = ehci_handshake(ehci, &ehci->regs->command, CMD_RUN, > > > > + 1, 100 * 1000); > > > > + else > > > > + rc = ehci_handshake(ehci, &ehci->regs->status, STS_HALT, > > > > + 0, 100 * 1000); > > > > > > > > up_write(&ehci_cf_port_reset_rwsem); > > > > > > > > diff --git a/drivers/usb/host/ehci-platform.c > > > > b/drivers/usb/host/ehci-platform.c > > > > index c70f2d0b4aaf..c3dc906274d9 100644 > > > > --- a/drivers/usb/host/ehci-platform.c > > > > +++ b/drivers/usb/host/ehci-platform.c > > > > @@ -297,6 +297,12 @@ static int ehci_platform_probe(struct > > platform_device *dev) > > > > "has-transaction-translator")) > > > > hcd->has_tt = 1; > > > > > > > > + if (of_device_is_compatible(dev->dev.of_node, > > > > + "aspeed,ast2500-ehci") || > > > > + of_device_is_compatible(dev->dev.of_node, > > > > + "aspeed,ast2600-ehci")) > > > > + ehci->is_aspeed = 1; > > > > + > > > > if (soc_device_match(quirk_poll_match)) > > > > priv->quirk_poll = true; > > > > > > > > diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h index > > > > 80bb823aa9fe..fdd073cc053b 100644 > > > > --- a/drivers/usb/host/ehci.h > > > > +++ b/drivers/usb/host/ehci.h > > > > @@ -219,6 +219,7 @@ struct ehci_hcd { /* one per > > controller */ > > > > unsigned need_oc_pp_cycle:1; /* MPC834X port power */ > > > > unsigned imx28_write_fix:1; /* For Freescale i.MX28 */ > > > > unsigned spurious_oc:1; > > > > + unsigned is_aspeed:1; > > > > > > > > /* required for usb32 quirk */ > > > > #define OHCI_CTRL_HCFS (3 << 6) > > > > -- > > > > 2.17.1 > > > > > > > > > > Hi, > > > > > > This is the friendly patch-bot of Greg Kroah-Hartman. You have sent > > > him a patch that has triggered this response. He used to manually > > > respond to these common problems, but in order to save his sanity (he > > > kept writing the same thing over and over, yet to different people), I > > > was created. Hopefully you will not take offence and will fix the > > > problem in your patch and resubmit it so that it can be accepted into > > > the Linux kernel tree. > > > > > > You are receiving this message because of the following common > > > error(s) as indicated below: > > > > > > - It looks like you did not use your "real" name for the patch on either > > > the Signed-off-by: line, or the From: line (both of which have to > > > match). Please read the kernel file, Documentation/SubmittingPatches > > > for how to do this correctly. > > > > > > - This looks like a new version of a previously submitted patch, but you > > > did not list below the --- line any changes from the previous version. > > > Please read the section entitled "The canonical patch format" in the > > > kernel file, Documentation/SubmittingPatches for what needs to be done > > > here to properly describe this. > > > > > > If you wish to discuss this problem further, or you have questions > > > about how to resolve this issue, please feel free to respond to this > > > email and Greg will reply once he has dug out from the pending patches > > > received from other developers. > > > > > > thanks, > > > > > > greg k-h's patch email bot > > > > Thank you Neal for the patch. I tried the fix on my CMM (AST2500) and Fuji > > (AST2600) BMC and it works on both platforms. > > > > Can you please address Greg's comments above and send out a new version? > > BTW, please don't forget to include Alan's Acked-by in the new version. > > > > Reviewed-by: Tao Ren > > Tested-by: Tao Ren > > > > > > Cheers, > > > > Tao > > Sure! I'll try to fix Greg's comments on next patch. I think the problem is the first one. > And thanks for your review & test. Both problems are real, please fix them.