From: Greg KH <gregkh@linuxfoundation.org>
To: Fei Li <fei1.li@intel.com>
Cc: linux-kernel@vger.kernel.org, yu1.wang@intel.com, shuox.liu@gmail.com
Subject: Re: [PATCH v4 2/2] virt: acrn: Introduce interfaces for virtual device creating/destroying
Date: Tue, 14 Sep 2021 09:00:48 +0200 [thread overview]
Message-ID: <YUBIoEYPP7e5+CR0@kroah.com> (raw)
In-Reply-To: <20210914062627.16431-3-fei1.li@intel.com>
On Tue, Sep 14, 2021 at 02:26:27PM +0800, Fei Li wrote:
> +struct acrn_vdev {
> + /*
> + * the identifier of the device, the low 32 bits represent the vendor
> + * id and device id of PCI device and the high 32 bits represent the
> + * device number of the legacy device
> + */
> + union {
> + __u64 value;
> + struct {
> + __u16 vendor;
> + __u16 device;
> + __u32 legacy_id;
What is the endian of these fields?
Please always specify them.
thanks,
greg k-h
next prev parent reply other threads:[~2021-09-14 7:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 6:26 [PATCH v4 0/2] Introduce some interfaces for ACRN hypervisor HSM driver Fei Li
2021-09-14 6:26 ` [PATCH v4 1/2] virt: acrn: Introduce interfaces for MMIO device passthrough Fei Li
2021-09-14 6:26 ` [PATCH v4 2/2] virt: acrn: Introduce interfaces for virtual device creating/destroying Fei Li
2021-09-14 7:00 ` Greg KH [this message]
2021-09-15 1:35 ` Li Fei1
2021-09-14 6:59 ` [PATCH v4 0/2] Introduce some interfaces for ACRN hypervisor HSM driver Greg KH
2021-09-15 1:44 ` Li Fei1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUBIoEYPP7e5+CR0@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=fei1.li@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shuox.liu@gmail.com \
--cc=yu1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox