From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FCF1C433F5 for ; Tue, 14 Sep 2021 07:01:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F0F6C60EC0 for ; Tue, 14 Sep 2021 07:01:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240358AbhINHC5 (ORCPT ); Tue, 14 Sep 2021 03:02:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:53392 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240419AbhINHCK (ORCPT ); Tue, 14 Sep 2021 03:02:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2C8E2610E6; Tue, 14 Sep 2021 07:00:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631602851; bh=yVMhOyi2NlCerH8Ao+NJSMjK/cz1/pt+EzZEoLHb3fc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jRdFaAlw/wmN3zMMzuRHAzJ4Ugc+65HAcdDPhWpYqEeKQ/15VVDORRhB7rrvToXms iUxFSvrG9oPpKrTuXx6pL3WWHJ2MzaldMlZL9sFJTT+M7AOaX16qSejenwgpCZ/RsP jYDXfFic+NpIVtIr8IzrDRE+wzgmOAtkUSzei3mI= Date: Tue, 14 Sep 2021 09:00:48 +0200 From: Greg KH To: Fei Li Cc: linux-kernel@vger.kernel.org, yu1.wang@intel.com, shuox.liu@gmail.com Subject: Re: [PATCH v4 2/2] virt: acrn: Introduce interfaces for virtual device creating/destroying Message-ID: References: <20210914062627.16431-1-fei1.li@intel.com> <20210914062627.16431-3-fei1.li@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210914062627.16431-3-fei1.li@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 14, 2021 at 02:26:27PM +0800, Fei Li wrote: > +struct acrn_vdev { > + /* > + * the identifier of the device, the low 32 bits represent the vendor > + * id and device id of PCI device and the high 32 bits represent the > + * device number of the legacy device > + */ > + union { > + __u64 value; > + struct { > + __u16 vendor; > + __u16 device; > + __u32 legacy_id; What is the endian of these fields? Please always specify them. thanks, greg k-h