From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sven Peter <sven@svenpeter.dev>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] usb: typec: tipd: Add an additional overflow check
Date: Tue, 14 Sep 2021 13:23:00 +0200 [thread overview]
Message-ID: <YUCGFJGiC/ekvmfZ@kroah.com> (raw)
In-Reply-To: <05fe66fe-e1a3-46ba-bbd6-8b0a41109b81@www.fastmail.com>
On Tue, Sep 14, 2021 at 01:18:16PM +0200, Sven Peter wrote:
>
>
> On Tue, Sep 14, 2021, at 13:00, Greg Kroah-Hartman wrote:
> > On Tue, Sep 14, 2021 at 12:42:53PM +0200, Sven Peter wrote:
> > > tps6598x_block_read already checks for the maximum length of the read
> > > but tps6598x_block_write does not. Add the symmetric check there as
> > > well.
> > >
> > > Signed-off-by: Sven Peter <sven@svenpeter.dev>
> > > ---
> > > drivers/usb/typec/tipd/core.c | 3 +++
> > > 1 file changed, 3 insertions(+)
> > >
> > > diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
> > > index c18ec3785592..70e2d0d410c9 100644
> > > --- a/drivers/usb/typec/tipd/core.c
> > > +++ b/drivers/usb/typec/tipd/core.c
> > > @@ -139,6 +139,9 @@ static int tps6598x_block_write(struct tps6598x *tps, u8 reg,
> > > {
> > > u8 data[TPS_MAX_LEN + 1];
> > >
> > > + if (WARN_ON(len + 1 > sizeof(data)))
> > > + return -EINVAL;
> >
> > No need to crash anything. If this is a valid thing for us to check,
> > let's check it and handle the error, but we should not reboot systems
> > that are running with panic-on-warn enabled, right?
>
> Sure, that makes sense. I guess the same point applies to the WARN_ON in
> the same check in tps6598x_block_read. I can add a patch to remove that one
> to v2 as well.
That would be great, thanks.
greg k-h
prev parent reply other threads:[~2021-09-14 11:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 10:42 [PATCH 1/2] usb: typec: tipd: Don't read/write more bytes than required Sven Peter
2021-09-14 10:42 ` [PATCH 2/2] usb: typec: tipd: Add an additional overflow check Sven Peter
2021-09-14 11:00 ` Greg Kroah-Hartman
2021-09-14 11:18 ` Sven Peter
2021-09-14 11:23 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUCGFJGiC/ekvmfZ@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox