From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20017C433F5 for ; Thu, 16 Sep 2021 22:13:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 04C296108F for ; Thu, 16 Sep 2021 22:13:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240783AbhIPWOe (ORCPT ); Thu, 16 Sep 2021 18:14:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:58142 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240764AbhIPWOc (ORCPT ); Thu, 16 Sep 2021 18:14:32 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CB7AA6108F; Thu, 16 Sep 2021 22:13:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631830390; bh=dsOuovH9Kp0/Y7aVaHgWs9poFvSiJI5QPHtFbQ7UB+U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ECs+MA7oh2od9NNE8nBOlbqxT7yq7iR/f4JXp6nWXxahLC/Ka6ZW8xVLiWPxs0lIB 97SE/93aqf2sTmlDvu1ucW52PJX+HwFQGeNuZDyZyJL6IGcT50DHEm76EnEr9XDti8 KkihsjNQ9iUrNKemFIN+23f10GEYNXnnVwcoT1ZNURNsHwJkOFeUv5s1vLThEEIITq g+TOOC6x3CWCewConmgDSqEcpuISMpmybj2KHUFvLZA+40SZYBo+cf63RLgSFewVor Rn60/6jCHVP0dPNK8l+cN67igpGAoUwQrigOvak4QlnxISYzZSvLbWJRJO77OCSt0H yvoqdWZhSDS9g== Date: Thu, 16 Sep 2021 18:13:08 -0400 From: Sasha Levin To: Marc Zyngier Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 5.13 345/380] KVM: arm64: vgic: move irq->get_input_level into an ops structure Message-ID: References: <20210916155803.966362085@linuxfoundation.org> <20210916155815.779126002@linuxfoundation.org> <87r1dobco8.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <87r1dobco8.wl-maz@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 16, 2021 at 07:25:27PM +0100, Marc Zyngier wrote: >On Thu, 16 Sep 2021 17:01:42 +0100, >Greg Kroah-Hartman wrote: >> >> From: Marc Zyngier >> >> [ Upstream commit db75f1a33f82ad332b6e139c5960e01999969d2c ] >> >> We already have the option to attach a callback to an interrupt >> to retrieve its pending state. As we are planning to expand this >> facility, move this callback into its own data structure. >> >> This will limit the size of individual interrupts as the ops >> structures can be shared across multiple interrupts. >> >> Signed-off-by: Marc Zyngier >> Signed-off-by: Sasha Levin >> --- >> arch/arm64/kvm/arch_timer.c | 8 ++++++-- >> arch/arm64/kvm/vgic/vgic.c | 14 +++++++------- >> include/kvm/arm_vgic.h | 28 +++++++++++++++++----------- >> 3 files changed, 30 insertions(+), 20 deletions(-) > >As I replied to Sasha earlier, I don't see a good reason to backport >this, as it doesn't improve anything on its own. Unless there is a >compelling reason to get this backported, I'd rather see it dropped. Yes, I'll drop it. I originally brought it as a dependency for a patch that ended up being dropped. Thanks for pointing it out! -- Thanks, Sasha