Re: [PATCH v7 16/19] staging: r8188eu: clean up rtw_read*() and rtw_write*()

Greg Kroah-Hartman
2021-09-17T14:46:09Z

On Fri, Sep 17, 2021 at 09:18:34AM +0200, Fabio M. De Francesco wrote:
> Clean up rtw_read{8,16,32}() and rtw_write{8,16,32,N}() in usb_ops_linux.c.
>
> 1) Rename variables:
> length => len
> pio_priv => io_priv
> pintfhdl => intfhdl
> wvalue => address.

Wait, why are you changing wvalue? Isn't that the USB name for this
variable in the USB message sent to the device? Check the USB spec
before changing this, that is a common field and probably should not be
changed.

thanks,

greg k-h