From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: David Heidelberg <david@ixit.cz>
Cc: Andy Gross <agross@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Manu Gautam <mgautam@codeaurora.org>,
linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: qcom: ipq4019: add dwc3 arch spec compatible
Date: Sun, 19 Sep 2021 23:16:53 -0500 [thread overview]
Message-ID: <YUgLNZlKbaqeCQYp@builder.lan> (raw)
In-Reply-To: <20210908193329.87992-2-david@ixit.cz>
On Wed 08 Sep 14:33 CDT 2021, David Heidelberg wrote:
> To be compilant with qcom,dwc3 definition
> - add compatible
> - rename dwc3@ to usb@
>
> No functional changes intended.
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> arch/arm/boot/dts/qcom-ipq4019.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-ipq4019.dtsi b/arch/arm/boot/dts/qcom-ipq4019.dtsi
> index a3ae5458ac68..25b7e10537df 100644
> --- a/arch/arm/boot/dts/qcom-ipq4019.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq4019.dtsi
> @@ -637,7 +637,7 @@ usb3_hs_phy: hsphy@a6000 {
> };
>
> usb3: usb3@8af8800 {
> - compatible = "qcom,dwc3";
> + compatible = "qcom,ipq4019-dwc3", "qcom,dwc3";
> reg = <0x8af8800 0x100>;
> #address-cells = <1>;
> #size-cells = <1>;
> @@ -648,7 +648,7 @@ usb3: usb3@8af8800 {
> ranges;
> status = "disabled";
>
> - dwc3@8a00000 {
> + usb@8a00000 {
As noted in a recent discussion, this causes the UDC name exposed in
sysfs to change. So even though it's contradicting the binding let's
keep it unchanged for now.
The compatible part looks good though, so can you please respin this
patch with that part only?
Thanks,
Bjorn
> compatible = "snps,dwc3";
> reg = <0x8a00000 0xf8000>;
> interrupts = <GIC_SPI 132 IRQ_TYPE_LEVEL_HIGH>;
> @@ -669,7 +669,7 @@ usb2_hs_phy: hsphy@a8000 {
> };
>
> usb2: usb2@60f8800 {
> - compatible = "qcom,dwc3";
> + compatible = "qcom,ipq4019-dwc3", "qcom,dwc3";
> reg = <0x60f8800 0x100>;
> #address-cells = <1>;
> #size-cells = <1>;
> @@ -680,7 +680,7 @@ usb2: usb2@60f8800 {
> ranges;
> status = "disabled";
>
> - dwc3@6000000 {
> + usb@6000000 {
> compatible = "snps,dwc3";
> reg = <0x6000000 0xf8000>;
> interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;
> --
> 2.33.0
>
next prev parent reply other threads:[~2021-09-20 4:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 19:33 [PATCH 1/2] dt-bindings: usb/qcom,dwc3: add ipq4019 compatible David Heidelberg
2021-09-08 19:33 ` [PATCH 2/2] ARM: dts: qcom: ipq4019: add dwc3 arch spec compatible David Heidelberg
2021-09-20 4:16 ` Bjorn Andersson [this message]
2021-09-09 6:18 ` [PATCH 1/2] dt-bindings: usb/qcom,dwc3: add ipq4019 compatible Greg Kroah-Hartman
2021-09-21 17:23 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUgLNZlKbaqeCQYp@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mgautam@codeaurora.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox