From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AB36C433F5 for ; Mon, 20 Sep 2021 20:07:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D0D261244 for ; Mon, 20 Sep 2021 20:07:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231158AbhITUIl (ORCPT ); Mon, 20 Sep 2021 16:08:41 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:65035 "EHLO relay1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236813AbhITUGj (ORCPT ); Mon, 20 Sep 2021 16:06:39 -0400 Received: (Authenticated sender: alexandre.belloni@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 2C649240006; Mon, 20 Sep 2021 20:05:10 +0000 (UTC) Date: Mon, 20 Sep 2021 22:05:09 +0200 From: Alexandre Belloni To: Will McVicker Cc: Catalin Marinas , Will Deacon , Alessandro Zummo , Lee Jones , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH v1 4/4] rtc: change HAVE_S3C_RTC default config logic Message-ID: References: <20210920190350.3860821-1-willmcvicker@google.com> <20210920190350.3860821-5-willmcvicker@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210920190350.3860821-5-willmcvicker@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/09/2021 19:03:49+0000, Will McVicker wrote: > Switches the default config logic of HAVE_S3C_RTC to use "default y if > (ARCH_EXYNOS && RTC_CLASS)" versus having ARCH_EXYNOS directly select > it. This provides vendors flexibility to disable the config if desired > or modularize it in the presence of a generic kernel. > > Verified this change doesn't impact the .config. > > Signed-off-by: Will McVicker Acked-by: Alexandre Belloni > --- > arch/arm64/Kconfig.platforms | 1 - > drivers/rtc/Kconfig | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > index a884e5da8b0f..f9f829aab511 100644 > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -91,7 +91,6 @@ config ARCH_BRCMSTB > > config ARCH_EXYNOS > bool "ARMv8 based Samsung Exynos SoC family" > - select HAVE_S3C_RTC if RTC_CLASS > select PINCTRL > select PM_GENERIC_DOMAINS if PM > help > diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig > index e1bc5214494e..40afdb37d2a5 100644 > --- a/drivers/rtc/Kconfig > +++ b/drivers/rtc/Kconfig > @@ -1406,6 +1406,7 @@ config RTC_DRV_OMAP > > config HAVE_S3C_RTC > bool > + default y if (ARCH_EXYNOS && RTC_CLASS) > help > This will include RTC support for Samsung SoCs. If > you want to include RTC support for any machine, kindly > -- > 2.33.0.464.g1972c5931b-goog > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com