public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Johan Jonker <jbx6244@gmail.com>
Cc: heiko@sntech.de, rui.zhang@intel.com, daniel.lezcano@linaro.org,
	amitk@kernel.org, p.zabel@pengutronix.de,
	linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/4] dt-bindings: thermal: allow more resets for tsadc node in rockchip-thermal.yaml
Date: Mon, 20 Sep 2021 17:16:48 -0500	[thread overview]
Message-ID: <YUkIUBs3FC4WKJ2M@robh.at.kernel.org> (raw)
In-Reply-To: <20210906120404.10005-1-jbx6244@gmail.com>

On Mon, Sep 06, 2021 at 02:04:01PM +0200, Johan Jonker wrote:
> The tsadc node in rk356x.dtsi has more resets defined then currently
> allowed by rockchip-thermal.yaml, so fix that in the documentation.
> The driver now uses the devm_reset_control_array_get() function,
> so reset-names is no longer required, but keep it for legacy reasons.

I don't think I'd deprecate it for that reason.

And removing it would break any kernel before the 
devm_reset_control_array_get change.

> 
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
>  .../devicetree/bindings/thermal/rockchip-thermal.yaml     | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml b/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml
> index b96ea277b..ee104e451 100644
> --- a/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml
> @@ -37,11 +37,16 @@ properties:
>        - const: apb_pclk
>  
>    resets:
> -    maxItems: 1
> +    minItems: 1
> +    maxItems: 3
>  
>    reset-names:
> +    deprecated: true
> +    minItems: 1
>      items:
>        - const: tsadc-apb
> +      - const: tsadc
> +      - const: tsadc-phy
>  
>    "#thermal-sensor-cells":
>      const: 1
> @@ -71,7 +76,6 @@ required:
>    - clocks
>    - clock-names
>    - resets
> -  - reset-names
>    - "#thermal-sensor-cells"
>  
>  additionalProperties: false
> -- 
> 2.20.1
> 
> 

      parent reply	other threads:[~2021-09-20 22:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-06 12:04 [RFC PATCH 1/4] dt-bindings: thermal: allow more resets for tsadc node in rockchip-thermal.yaml Johan Jonker
2021-09-06 12:04 ` [RFC PATCH 2/4] dt-bindings: thermal: remove redundant comments from rockchip-thermal.yaml Johan Jonker
2021-09-20 22:17   ` Rob Herring
2021-09-06 12:04 ` [RFC PATCH 3/4] thermal: rockchip_thermal: allow more resets for tsadc node Johan Jonker
2021-09-06 12:04 ` [RFC PATCH 4/4] arm64: dts: fix resets in tsadc node for rk356x.dtsi Johan Jonker
2021-09-20 22:16 ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YUkIUBs3FC4WKJ2M@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=amitk@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=jbx6244@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=p.zabel@pengutronix.de \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox