From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14B4BC4332F for ; Tue, 21 Sep 2021 08:18:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E3A5561019 for ; Tue, 21 Sep 2021 08:18:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231133AbhIUIT7 (ORCPT ); Tue, 21 Sep 2021 04:19:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230421AbhIUIT5 (ORCPT ); Tue, 21 Sep 2021 04:19:57 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80FEEC061574 for ; Tue, 21 Sep 2021 01:18:29 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id i23so36683523wrb.2 for ; Tue, 21 Sep 2021 01:18:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=nNVr+7Y3y0DjrwtJDXXuwygIO9f2oy/hZH+WtVNESd0=; b=wh+sim1Zg6DC6668hwXycB8Dyk/tZS7ZXwtfBWceYu6QVs0o4Opzx6VZxvwiHZlAEA tps08+EK9AepLKtndlNIkswpBeoyg8RljktaQHSkzUiMPN4HfIvMD6bhZ8BLRWWRk6Oe pNcoQ4H98LXnyB6NuFzEui8UU74+9JLcvDoaoUCuNYuaUwtS8gtVkl0W600Y4K16Mpg+ jw5fYR+Sx0OgNA8bW1H553LidGwULO43ERxbq+3mWVMA7N68xPrabyIy3JBvWMGLs7HN Haj7NHF93cDl7DGOq3sCTgjm8891XRki4Sujc4ZWFekx0Qs0WdlPJ8nt4VDG/R9ZWB7k aNCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=nNVr+7Y3y0DjrwtJDXXuwygIO9f2oy/hZH+WtVNESd0=; b=l6sglKQiB5Xt6Wh0w6JQdwV/XyfupgZs+VwKoipILI05pUHlG44aVZ6+xvmfdHMI7R Ag/WIOqDwLdIY+iZbaad9wa7KSg/n6/QlR40MSbhDaUbCKnDhTzxprlZoEP7rJRTFSn0 S7rkufhFLezP1FD+1RMkezDQ3U3yitd5jTAA9dOsLFFK/g/N/uQFoqdP95Uow0P4w1GZ LVTXFHebv4kzyaKFloFZmuQuGvD9e2zhpRtm9HD3aF/9Aa5KWuBeH6bzLwjfxvHyKyDN J/g2MagV6NKZn2exsXYmDPnIVB9eBVeKNR0gUHGaVJ+rS8BBt/ePnVVU3VDm+jkvSy3M v6Dg== X-Gm-Message-State: AOAM533rzm5Cn/sd2g9DCciuj18DBfdrUoCxpiOt4odl/+88k8pOMuX4 LJwWL1Gk/nAXvLBmHaleNxNqsLGQ7JLZJw== X-Google-Smtp-Source: ABdhPJwRjVdNHhTPUc8PqFcM0ueenx5C6EDv8QgXwM59Ary8kojlg28OQkgEpgIs9zyANEgUQxxaSA== X-Received: by 2002:a7b:ce06:: with SMTP id m6mr3173294wmc.85.1632212308066; Tue, 21 Sep 2021 01:18:28 -0700 (PDT) Received: from google.com ([95.148.6.233]) by smtp.gmail.com with ESMTPSA id b188sm2028749wmd.39.2021.09.21.01.18.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Sep 2021 01:18:27 -0700 (PDT) Date: Tue, 21 Sep 2021 09:18:25 +0100 From: Lee Jones To: Krzysztof Kozlowski Cc: Will McVicker , Catalin Marinas , Will Deacon , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v1 3/4] pinctrl: samsung: change PINCTRL_EXYNOS default config logic Message-ID: References: <20210920190350.3860821-1-willmcvicker@google.com> <20210920190350.3860821-4-willmcvicker@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 21 Sep 2021, Krzysztof Kozlowski wrote: > On 20/09/2021 21:03, Will McVicker wrote: > > Switching the default config logic of PINCTRL_EXYNOS to use "default > > y if ARCH_EXYNOS" versus having ARCH_EXYNOS directly select the config. > > This gives vendors the flexibility to disable the config or modularize > > it in the presence of a generic kernel. > > Reasoning is incorrect. This is an essential driver which CANNOT be > disabled for any kernel having ARCH_EXYNOS or ARCH_S5PV210. You are > trying to prepare it for some out-of-tree code? Please, upstream your > code instead. No additional code is required to build a generic kernel. The only difference would be a vendor's defconfig/fragment. The aim of this set is to provide more flexibility around how driver symbols can be configured via Kconfig. Currently if ARCH_EXYNOS (which is required if we wish to provide SERIAL_SAMSUNG as an option) is enabled it blindly enables lots of symbols without recourse. > > Verified this change doesn't effect the .config. > > > > Signed-off-by: Will McVicker > > --- > > arch/arm64/Kconfig.platforms | 1 - > > drivers/pinctrl/samsung/Kconfig | 1 + > > 2 files changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > > index 6a006490c9b9..a884e5da8b0f 100644 > > --- a/arch/arm64/Kconfig.platforms > > +++ b/arch/arm64/Kconfig.platforms > > @@ -93,7 +93,6 @@ config ARCH_EXYNOS > > bool "ARMv8 based Samsung Exynos SoC family" > > select HAVE_S3C_RTC if RTC_CLASS > > select PINCTRL > > - select PINCTRL_EXYNOS > > select PM_GENERIC_DOMAINS if PM > > help > > This enables support for ARMv8 based Samsung Exynos SoC family. > > diff --git a/drivers/pinctrl/samsung/Kconfig b/drivers/pinctrl/samsung/Kconfig > > index dfd805e76862..483acb8ac1f6 100644 > > --- a/drivers/pinctrl/samsung/Kconfig > > +++ b/drivers/pinctrl/samsung/Kconfig > > @@ -12,6 +12,7 @@ config PINCTRL_EXYNOS > > bool "Pinctrl common driver part for Samsung Exynos SoCs" > > depends on OF_GPIO > > depends on ARCH_EXYNOS || ARCH_S5PV210 || COMPILE_TEST > > + default y if ARCH_EXYNOS > > default ARCH_EXYNOS || ARCH_S5PV210 > ... and update all mach Kconfigs. > > > select PINCTRL_SAMSUNG > > select PINCTRL_EXYNOS_ARM if ARM && (ARCH_EXYNOS || ARCH_S5PV210) > > select PINCTRL_EXYNOS_ARM64 if ARM64 && ARCH_EXYNOS > > > > > Best regards, > Krzysztof -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog