From: Greg KH <gregkh@linuxfoundation.org>
To: Jeya R <jeyr@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, srinivas.kandagatla@linaro.org,
linux-kernel@vger.kernel.org, fastrpc.upstream@qti.qualcomm.com
Subject: Re: [RESEND PATCH v2] misc: fastrpc: fix improper packet size calculation
Date: Tue, 21 Sep 2021 13:50:14 +0200 [thread overview]
Message-ID: <YUnG9j1j9EmcocJ1@kroah.com> (raw)
In-Reply-To: <1632223981-30356-1-git-send-email-jeyr@codeaurora.org>
On Tue, Sep 21, 2021 at 05:03:01PM +0530, Jeya R wrote:
> The buffer list is sorted and this is not being considered while
> calculating packet size. This would lead to improper copy length
> calculation for non-dmaheap buffers which would eventually cause
> sending improper buffers to DSP.
>
> Fixes: c68cfb718c8f ("misc: fastrpc: Add support for context Invoke method")
> Signed-off-by: Jeya R <jeyr@codeaurora.org>
> Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>
> Changes in v2:
> - updated commit message to proper format
> - added fixes tag to commit message
> - removed unnecessary variable initialization
> - removed length check during payload calculation
> ---
> drivers/misc/fastrpc.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
Again, please read the documentation, changes go below the --- line.
I am _SURE_ there is a guide somewhere at your employer for how to do
all of this properly, right?
thanks,
greg k-h
next prev parent reply other threads:[~2021-09-21 11:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 11:33 [RESEND PATCH v2] misc: fastrpc: fix improper packet size calculation Jeya R
2021-09-21 11:50 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-09-21 11:44 Jeya R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUnG9j1j9EmcocJ1@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=fastrpc.upstream@qti.qualcomm.com \
--cc=jeyr@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox