From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AE3EC433FE for ; Tue, 21 Sep 2021 21:59:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 181F661166 for ; Tue, 21 Sep 2021 21:59:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235828AbhIUWA5 (ORCPT ); Tue, 21 Sep 2021 18:00:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235766AbhIUWA4 (ORCPT ); Tue, 21 Sep 2021 18:00:56 -0400 Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1AA19C061574 for ; Tue, 21 Sep 2021 14:59:27 -0700 (PDT) Received: by mail-ot1-x331.google.com with SMTP id l7-20020a0568302b0700b0051c0181deebso508730otv.12 for ; Tue, 21 Sep 2021 14:59:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ERZn09RzvY8rn9MTPmUjdnDe5Cvx6gD06HefJz6Y3b4=; b=SQFXCpc7vgjKtuYXKBRS76J6eM5IhO65sgVlBujADSM3DO4deLw0qaTSiT3daTesCl Kb76k0R3Wcx9gZCg+FH/2kzDk11VMaHp+RWx6SI7ie8e/9iKbleiIqeqn13orm1Z1zf3 Zz3LfkO17f2uagRueFDiZW7wqVjyRKCAd+itSe+OZuFBByEB83+m4U/sqrN/KeZhLq7Z qk7iyk828b25Wgd6Y/EZJfd6sK5RAePlMqxXOCA025/Q1NEr/CLov0z3XhP+cCQdwCZf rh7nOQRFbQ48/EFetpE2tXvA4mmFK3yzGOPomy9anWMKtUpKaJ7/NO7Bi1E/4krwK7Qu mQ/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ERZn09RzvY8rn9MTPmUjdnDe5Cvx6gD06HefJz6Y3b4=; b=Ady9MANWE9S4wksnXiF85NNeKc32UBgywRoVL3kOQpz7cgZEcU4Gx/9s3kdF32swc9 lKXc4y4MF67jFDH7/n5INFHw8XvJORMOLG8zsYBk0h/uyzXwqLiljseNHpwZaYL/qAZL 1uzV9IBit+elogVkirbQ+jEZuRUseFZXeJjGWOSrRvK5ihaQ701A4INr4yBIcrLbEov7 GI+i5wo9lMwdpj+n1R0JSafbFxER+vO4LSLPHXL2tLkZCkBMfMu5cOK1kxgDFWP1o5ty n+HNbXnXZkfFiscM8PPpjFcP2z2JflzgBfFQuNMjuwAHWBWuanUG/dlbY7G/RwGmdHu2 Ftmw== X-Gm-Message-State: AOAM530NIPvzGb0pevGZ+m8sI6sri+szfrTvXzNMELvCBKIcr4e1KyGz uio/Yu/UiCFX4Mo7VTtjV7+IDA== X-Google-Smtp-Source: ABdhPJxmVxfbRCUjhNToAtcJMU5kjhsgQITrJ1T/7CkH3AvdQJofm2nbdZgkn8AGULg+tYI4vAlW/w== X-Received: by 2002:a9d:192c:: with SMTP id j44mr8721188ota.302.1632261566430; Tue, 21 Sep 2021 14:59:26 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id n15sm62070oic.25.2021.09.21.14.59.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Sep 2021 14:59:26 -0700 (PDT) Date: Tue, 21 Sep 2021 16:59:24 -0500 From: Bjorn Andersson To: Shawn Guo Cc: Linus Walleij , Rob Herring , Loic Poulain , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: qcom: Add QCM2290 pinctrl bindings Message-ID: References: <20210914074542.12957-1-shawn.guo@linaro.org> <20210914074542.12957-2-shawn.guo@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210914074542.12957-2-shawn.guo@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 14 Sep 02:45 CDT 2021, Shawn Guo wrote: > Add device tree bindings for QCM2290 pinctrl. > > Signed-off-by: Shawn Guo > --- > .../pinctrl/qcom,qcm2290-pinctrl.yaml | 186 ++++++++++++++++++ > 1 file changed, 186 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml > [..] > +'$defs': > + qcom-qcm2290-tlmm-state: > + type: object > + description: > + Pinctrl node's client devices use subnodes for desired pin configuration. > + Client device subnodes use below standard properties. > + $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" > + > + properties: > + pins: > + description: > + List of gpio pins affected by the properties specified in this > + subnode. > + items: > + oneOf: > + - pattern: "^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-2])$" ^gpio([0-9]|[1-9][0-9]|1[0-1][0-9]|12[0-6])$ To make it cover the entire gpio space. The rest looks good! Regards, Bjorn