From: Greg KH <gregkh@linuxfoundation.org>
To: "Longpeng (Mike,
Cloud Infrastructure Service Product Dept.)"
<longpeng2@huawei.com>
Cc: "andraprs@amazon.com" <andraprs@amazon.com>,
"lexnv@amazon.com" <lexnv@amazon.com>,
"alcioa@amazon.com" <alcioa@amazon.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Gonglei (Arei)" <arei.gonglei@huawei.com>,
"kamal@canonical.com" <kamal@canonical.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"sgarzare@redhat.com" <sgarzare@redhat.com>,
"stefanha@redhat.com" <stefanha@redhat.com>,
"vkuznets@redhat.com" <vkuznets@redhat.com>,
"ne-devel-upstream@amazon.com" <ne-devel-upstream@amazon.com>
Subject: Re: [PATCH v2 3/4] nitro_enclaves: add test framework for the misc functionality
Date: Wed, 22 Sep 2021 07:55:01 +0200 [thread overview]
Message-ID: <YUrFNTQFnFMTVvnm@kroah.com> (raw)
In-Reply-To: <511306b230ed4347a4ba3a2f4d5d4e64@huawei.com>
On Wed, Sep 22, 2021 at 12:33:19AM +0000, Longpeng (Mike, Cloud Infrastructure Service Product Dept.) wrote:
>
>
> > -----Original Message-----
> > From: Greg KH [mailto:gregkh@linuxfoundation.org]
> > Sent: Tuesday, September 21, 2021 11:21 PM
> > To: Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
> > <longpeng2@huawei.com>
> > Cc: andraprs@amazon.com; lexnv@amazon.com; alcioa@amazon.com;
> > linux-kernel@vger.kernel.org; Gonglei (Arei) <arei.gonglei@huawei.com>;
> > kamal@canonical.com; pbonzini@redhat.com; sgarzare@redhat.com;
> > stefanha@redhat.com; vkuznets@redhat.com; ne-devel-upstream@amazon.com
> > Subject: Re: [PATCH v2 3/4] nitro_enclaves: add test framework for the misc
> > functionality
> >
> > On Tue, Sep 21, 2021 at 11:10:38PM +0800, Longpeng(Mike) wrote:
> > > Add test framework for the misc functionality.
> >
> > What is "the misc functionality"?
> >
>
> The functionalities provided in the ne_misc_dev.c
You need to be more verbose here in this commit message please, so that
everyone can properly understand what is going on.
>
> > >
> > > Signed-off-by: Longpeng(Mike) <longpeng2@huawei.com>
> > > ---
> > > drivers/virt/nitro_enclaves/Kconfig | 8 ++++++++
> > > drivers/virt/nitro_enclaves/ne_misc_dev.c | 27
> > +++++++++++++++++++++++++++
> > > drivers/virt/nitro_enclaves/ne_misc_test.c | 17 +++++++++++++++++
> > > 3 files changed, 52 insertions(+)
> > > create mode 100644 drivers/virt/nitro_enclaves/ne_misc_test.c
> >
> > What changed from v1?
> >
>
> The unit tests are new added in v2, described in the cover letter.
Ah, the cover letter showed up _after_ these commits did :(
thanks,
greg k-h
next prev parent reply other threads:[~2021-09-22 5:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 15:10 [PATCH v2 0/4] merge contiguous physical memory regions Longpeng(Mike)
2021-09-21 15:10 ` [PATCH v2 1/4] nitro_enclaves: " Longpeng(Mike)
2021-09-21 15:20 ` Greg KH
2021-09-22 1:09 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2021-09-21 15:20 ` Greg KH
2021-09-22 0:27 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2021-10-03 13:00 ` Paraschiv, Andra-Irina
2021-10-05 13:54 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2021-10-06 11:11 ` Paraschiv, Andra-Irina
2021-09-21 15:10 ` [PATCH v2 2/4] nitro_enclaves: sanity check the physical region during setting Longpeng(Mike)
2021-10-03 13:29 ` Paraschiv, Andra-Irina
2021-09-21 15:10 ` [PATCH v2 3/4] nitro_enclaves: add test framework for the misc functionality Longpeng(Mike)
2021-09-21 15:20 ` Greg KH
2021-09-22 0:33 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2021-09-22 5:55 ` Greg KH [this message]
2021-10-03 13:49 ` Paraschiv, Andra-Irina
2021-10-07 2:05 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2021-10-07 15:37 ` Paraschiv, Andra-Irina
2021-09-21 15:10 ` [PATCH v2 4/4] nitro_enclaves: add kunit tests for physical contiguous region merging Longpeng(Mike)
2021-10-03 14:14 ` Paraschiv, Andra-Irina
2021-09-27 7:00 ` [PATCH v2 0/4] merge contiguous physical memory regions Paraschiv, Andra-Irina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUrFNTQFnFMTVvnm@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alcioa@amazon.com \
--cc=andraprs@amazon.com \
--cc=arei.gonglei@huawei.com \
--cc=kamal@canonical.com \
--cc=lexnv@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longpeng2@huawei.com \
--cc=ne-devel-upstream@amazon.com \
--cc=pbonzini@redhat.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox