From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72517C433EF for ; Wed, 22 Sep 2021 05:55:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 516B7611C6 for ; Wed, 22 Sep 2021 05:55:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232478AbhIVF4f (ORCPT ); Wed, 22 Sep 2021 01:56:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:39264 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232467AbhIVF4d (ORCPT ); Wed, 22 Sep 2021 01:56:33 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8006161100; Wed, 22 Sep 2021 05:55:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1632290104; bh=fqOx+5HG3EUzbxzj2g+XQRB+FT+VPlXaUP3m8k56SZI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gFwh9TxAhbgi9duNeEa4Lp8jcJgXa+7P6Cv6zvupcAykSsSIVWS2f0dEtRq3ynewY Zsx34yCeIGbjTsb0e1qVYc6pG1AFUaoAjMJL4/dIGS1Y9Ii9ey0Z9/T2TW/QINATu6 XI7GSLuyx9IbdkCctA7Y4rfplBKQ9IYKHFhSJY54= Date: Wed, 22 Sep 2021 07:55:01 +0200 From: Greg KH To: "Longpeng (Mike, Cloud Infrastructure Service Product Dept.)" Cc: "andraprs@amazon.com" , "lexnv@amazon.com" , "alcioa@amazon.com" , "linux-kernel@vger.kernel.org" , "Gonglei (Arei)" , "kamal@canonical.com" , "pbonzini@redhat.com" , "sgarzare@redhat.com" , "stefanha@redhat.com" , "vkuznets@redhat.com" , "ne-devel-upstream@amazon.com" Subject: Re: [PATCH v2 3/4] nitro_enclaves: add test framework for the misc functionality Message-ID: References: <20210921151039.1502-1-longpeng2@huawei.com> <20210921151039.1502-4-longpeng2@huawei.com> <511306b230ed4347a4ba3a2f4d5d4e64@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <511306b230ed4347a4ba3a2f4d5d4e64@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 22, 2021 at 12:33:19AM +0000, Longpeng (Mike, Cloud Infrastructure Service Product Dept.) wrote: > > > > -----Original Message----- > > From: Greg KH [mailto:gregkh@linuxfoundation.org] > > Sent: Tuesday, September 21, 2021 11:21 PM > > To: Longpeng (Mike, Cloud Infrastructure Service Product Dept.) > > > > Cc: andraprs@amazon.com; lexnv@amazon.com; alcioa@amazon.com; > > linux-kernel@vger.kernel.org; Gonglei (Arei) ; > > kamal@canonical.com; pbonzini@redhat.com; sgarzare@redhat.com; > > stefanha@redhat.com; vkuznets@redhat.com; ne-devel-upstream@amazon.com > > Subject: Re: [PATCH v2 3/4] nitro_enclaves: add test framework for the misc > > functionality > > > > On Tue, Sep 21, 2021 at 11:10:38PM +0800, Longpeng(Mike) wrote: > > > Add test framework for the misc functionality. > > > > What is "the misc functionality"? > > > > The functionalities provided in the ne_misc_dev.c You need to be more verbose here in this commit message please, so that everyone can properly understand what is going on. > > > > > > > Signed-off-by: Longpeng(Mike) > > > --- > > > drivers/virt/nitro_enclaves/Kconfig | 8 ++++++++ > > > drivers/virt/nitro_enclaves/ne_misc_dev.c | 27 > > +++++++++++++++++++++++++++ > > > drivers/virt/nitro_enclaves/ne_misc_test.c | 17 +++++++++++++++++ > > > 3 files changed, 52 insertions(+) > > > create mode 100644 drivers/virt/nitro_enclaves/ne_misc_test.c > > > > What changed from v1? > > > > The unit tests are new added in v2, described in the cover letter. Ah, the cover letter showed up _after_ these commits did :( thanks, greg k-h