public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: Linux Doc Mailing List <linux-doc@vger.kernel.org>,
	linux-kernel@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>,
	John Fastabend <john.fastabend@gmail.com>,
	KP Singh <kpsingh@kernel.org>, Kees Cook <keescook@chromium.org>,
	Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
	Tony Luck <tony.luck@intel.com>, Yonghong Song <yhs@fb.com>,
	bpf@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v3 0/7] get_abi.pl: Check for missing symbols at the ABI specs
Date: Wed, 22 Sep 2021 10:43:42 +0200	[thread overview]
Message-ID: <YUrsvgf3JXUPQ2Vo@kroah.com> (raw)
In-Reply-To: <YUrlFjotiFTYKXOV@kroah.com>

On Wed, Sep 22, 2021 at 10:11:02AM +0200, Greg Kroah-Hartman wrote:
> On Wed, Sep 22, 2021 at 09:36:09AM +0200, Mauro Carvalho Chehab wrote:
> > It sounds it took quite a while handling iommu cap, which sounds weird, as
> > it should be looking just 3 What expressions:
> > 
> > 	[07:43:06] What: /sys/class/iommu/.*/amd\-iommu/cap
> > 	[07:43:06] What: /sys/class/iommu/.*/intel\-iommu/cap
> > 	[07:43:06] What: /sys/devices/pci.*.*.*.*\:.*.*/0000\:.*.*\:.*.*..*/dma/dma.*chan.*/quickdata/cap
> > 
> > Maybe there was a memory starvation while running the script, causing
> > swaps. Still, it is weird that it would happen there, as the hashes
> > and arrays used at the script are all allocated before it starts the
> > search logic. Here, the allocation part takes ~2 seconds.
> 
> No memory starvation here, this thing is a beast:
> 	$ free -h
> 	               total        used        free      shared  buff/cache   available
> 	Mem:           251Gi        36Gi        13Gi       402Mi       202Gi       212Gi
> 	Swap:          4.0Gi       182Mi       3.8Gi
> 
> 	$ nproc
> 	64
> 
> 
> > At least on my Dell Precision 5820 (12 cpu threads), the amount of memory it
> > uses is not huge:
> > 
> >     $ /usr/bin/time -v ./scripts/get_abi.pl undefined >/dev/null
> > 	Command being timed: "./scripts/get_abi.pl undefined"
> > 	User time (seconds): 12.68
> > 	System time (seconds): 1.29
> > 	Percent of CPU this job got: 99%
> > 	Elapsed (wall clock) time (h:mm:ss or m:ss): 0:13.98
> > 	Average shared text size (kbytes): 0
> > 	Average unshared data size (kbytes): 0
> > 	Average stack size (kbytes): 0
> > 	Average total size (kbytes): 0
> > 	Maximum resident set size (kbytes): 212608
> > 	Average resident set size (kbytes): 0
> > 	Major (requiring I/O) page faults: 0
> > 	Minor (reclaiming a frame) page faults: 52003
> > 	Voluntary context switches: 1
> > 	Involuntary context switches: 56
> > 	Swaps: 0
> > 	File system inputs: 0
> > 	File system outputs: 0
> > 	Socket messages sent: 0
> > 	Socket messages received: 0
> > 	Signals delivered: 0
> > 	Page size (bytes): 4096
> > 	Exit status: 0
> > 
> > Unfortunately, I don't have any amd-based machine here, but I'll
> > try to run it later on a big arm server and see how it behaves.
> 
> I'll run that and get back to you in 30 minutes :)

$ /usr/bin/time -v ./scripts/get_abi.pl undefined > /dev/null
	Command being timed: "./scripts/get_abi.pl undefined"
	User time (seconds): 1756.94
	System time (seconds): 0.76
	Percent of CPU this job got: 99%
	Elapsed (wall clock) time (h:mm:ss or m:ss): 29:18.94
	Average shared text size (kbytes): 0
	Average unshared data size (kbytes): 0
	Average stack size (kbytes): 0
	Average total size (kbytes): 0
	Maximum resident set size (kbytes): 228116
	Average resident set size (kbytes): 0
	Major (requiring I/O) page faults: 0
	Minor (reclaiming a frame) page faults: 55862
	Voluntary context switches: 1
	Involuntary context switches: 17205
	Swaps: 0
	File system inputs: 0
	File system outputs: 0
	Socket messages sent: 0
	Socket messages received: 0
	Signals delivered: 0
	Page size (bytes): 4096
	Exit status: 0


      reply	other threads:[~2021-09-22  8:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-18  9:52 [PATCH v3 0/7] get_abi.pl: Check for missing symbols at the ABI specs Mauro Carvalho Chehab
2021-09-18  9:52 ` [PATCH v3 1/7] scripts: get_abi.pl: Better handle multiple What parameters Mauro Carvalho Chehab
2021-09-18  9:52 ` [PATCH v3 2/7] scripts: get_abi.pl: Check for missing symbols at the ABI specs Mauro Carvalho Chehab
2021-09-18  9:52 ` [PATCH v3 3/7] scripts: get_abi.pl: detect softlinks Mauro Carvalho Chehab
2021-09-18  9:52 ` [PATCH v3 4/7] scripts: get_abi.pl: add an option to filter undefined results Mauro Carvalho Chehab
2021-09-18  9:52 ` [PATCH v3 5/7] scripts: get_abi.pl: don't skip what that ends with wildcards Mauro Carvalho Chehab
2021-09-18  9:52 ` [PATCH v3 6/7] scripts: get_abi.pl: Ignore fs/cgroup sysfs nodes earlier Mauro Carvalho Chehab
2021-09-18  9:52 ` [PATCH v3 7/7] scripts: get_abi.pl: add a graph to speedup the undefined algorithm Mauro Carvalho Chehab
2021-09-21 16:52 ` [PATCH v3 0/7] get_abi.pl: Check for missing symbols at the ABI specs Greg Kroah-Hartman
2021-09-21 18:16   ` Mauro Carvalho Chehab
2021-09-22  5:43     ` Greg Kroah-Hartman
2021-09-22  6:22       ` Greg Kroah-Hartman
2021-09-22  7:36         ` Mauro Carvalho Chehab
2021-09-22  8:11           ` Greg Kroah-Hartman
2021-09-22  8:43             ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YUrsvgf3JXUPQ2Vo@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=anton@enomsg.org \
    --cc=bpf@vger.kernel.org \
    --cc=ccross@android.com \
    --cc=corbet@lwn.net \
    --cc=john.fastabend@gmail.com \
    --cc=kafai@fb.com \
    --cc=keescook@chromium.org \
    --cc=kpsingh@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab+huawei@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=songliubraving@fb.com \
    --cc=tony.luck@intel.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox