From: Andrew Lunn <andrew@lunn.ch>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com,
robh+dt@kernel.org, kostap@marvell.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] arm/arm64: dts: Enable 2.5G Ethernet port on CN9130-CRB
Date: Fri, 8 Oct 2021 01:45:20 +0200 [thread overview]
Message-ID: <YV+GkHONfzvYNS4R@lunn.ch> (raw)
In-Reply-To: <20211007230619.957016-2-chris.packham@alliedtelesis.co.nz>
On Fri, Oct 08, 2021 at 12:06:18PM +1300, Chris Packham wrote:
> Enable the 2.5G Ethernet port by setting the status to "okay" and the
> phy-mode to "2500base-x" on the cn9130-crb boards. Tested on a
> CN9130-CRB-A.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
>
> The Marvell SDK adds 2500base-t and uses it in the equivalent dtsi but
> looking at the documentation for both the SoC and the PHY I think
> 2500base-x is correct for the system interface (the line side is
> 2500base-t).
2500base-t does not make any sense. It does not even exist in
mainline.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2021-10-07 23:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 23:06 [PATCH 0/2] arm/arm64: dts: Enable more network hardware Chris Packham
2021-10-07 23:06 ` [PATCH 1/2] arm/arm64: dts: Enable 2.5G Ethernet port on CN9130-CRB Chris Packham
2021-10-07 23:45 ` Andrew Lunn [this message]
2021-10-13 14:52 ` Gregory CLEMENT
2021-10-17 22:15 ` Chris Packham
2021-11-09 1:00 ` Chris Packham
2021-10-07 23:06 ` [PATCH 2/2] arm/arm64: dts: Add MV88E6393X to CN9130-CRB device tree Chris Packham
2021-10-07 23:51 ` Andrew Lunn
2021-10-08 0:09 ` Chris Packham
2021-10-10 14:45 ` Andrew Lunn
2021-10-10 15:21 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YV+GkHONfzvYNS4R@lunn.ch \
--to=andrew@lunn.ch \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=kostap@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox