public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: ChiYuan Huang <u0084500@gmail.com>
Cc: oder_chiou@realtek.com, perex@perex.cz, tiwai@suse.com,
	Rob Herring <robh+dt@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	alsa-devel@alsa-project.org, lkml <linux-kernel@vger.kernel.org>,
	cy_huang <cy_huang@richtek.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>, allen lin <allen_lin@richtek.com>
Subject: Re: [PATCH 1/2] ASoC: dt-bindings: rt9120: Add initial bindings
Date: Thu, 7 Oct 2021 14:45:43 +0100	[thread overview]
Message-ID: <YV76ByQWKvKNOvF0@sirena.org.uk> (raw)
In-Reply-To: <CADiBU38zCZk_P-q8BtbPfdeSacUF7LOvQYUFgvidbWZwcLY=wA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1485 bytes --]

On Thu, Oct 07, 2021 at 10:44:49AM +0800, ChiYuan Huang wrote:
> ChiYuan Huang <u0084500@gmail.com> 於 2021年10月6日 週三 下午4:47寫道:
> > ChiYuan Huang <u0084500@gmail.com> 於 2021年10月5日 週二 下午8:39寫道:
> > > Mark Brown <broonie@kernel.org> 於 2021年10月5日 週二 下午8:29寫道:

> > > > > > I would expect this to be done through the regulator bindings, they
> > > > > > would allow the driver to query the supply voltage.

> > > > Please don't take things off-list unless there is a really strong reason
> > > > to do so.  Sending things to the list ensures that everyone gets a
> > > > chance to read and comment on things.

> > After contacting our HW RD, to support DVDD 1.8V not just SW config,
> > also HW connections.
> > To get only DVDD supply voltage is not enough to meet the HW design.
> > The property seems indeed and need to be used by user's HW connection.

> > Can this property to be kept?

> After thinking, This property name may be improper.
> I think this change depends on HW external circuit for lowv application.
> Currently, I'm modifying the V3 change, this property name also affect
> the property parsing code change.
> May I directly change the name to 'richtek,dvdd-lowv-application' and
> submit the patch v3?

I still don't understand why you wouldn't describe this through the
regulator bindings, those exist to describe the physical supplies ont he
board and their constraints.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2021-10-07 13:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-05  1:16 [PATCH 1/2] ASoC: dt-bindings: rt9120: Add initial bindings cy_huang
2021-10-05  1:16 ` [PATCH 2/2] ASoC: rt9120: Add rt9210 audio amplifier support cy_huang
2021-10-05 11:54   ` Mark Brown
     [not found]     ` <CADiBU38X6nY1D7NpgW8+61AX6rUU7jngnPagryDKxUAKdtGjAg@mail.gmail.com>
2021-10-05 12:41       ` ChiYuan Huang
     [not found]       ` <YVxIv6NOiVdNSkXf@sirena.org.uk>
2021-10-06  9:09         ` ChiYuan Huang
2021-10-05 11:49 ` [PATCH 1/2] ASoC: dt-bindings: rt9120: Add initial bindings Mark Brown
     [not found]   ` <CADiBU39dvKS_a5FDgw9yMVFe8Uycn6bfjGwBWq+7MN_DdxkL1g@mail.gmail.com>
     [not found]     ` <YVxFMaPhZdAFniMa@sirena.org.uk>
2021-10-05 12:39       ` ChiYuan Huang
2021-10-06  8:47         ` ChiYuan Huang
2021-10-07  2:44           ` ChiYuan Huang
2021-10-07 13:45             ` Mark Brown [this message]
2021-10-08  0:25               ` ChiYuan Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YV76ByQWKvKNOvF0@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=allen_lin@richtek.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=cy_huang@richtek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oder_chiou@realtek.com \
    --cc=perex@perex.cz \
    --cc=robh+dt@kernel.org \
    --cc=tiwai@suse.com \
    --cc=u0084500@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox