From: Borislav Petkov <bp@alien8.de>
To: Yazen Ghannam <yazen.ghannam@amd.com>
Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com,
rric@kernel.org, Smita.KoralahalliChannabasappa@amd.com
Subject: Re: [PATCH] EDAC/amd64: Handle three rank interleaving mode
Date: Thu, 7 Oct 2021 12:57:41 +0200 [thread overview]
Message-ID: <YV7SpRD3b0eRkXcQ@zn.tnic> (raw)
In-Reply-To: <20211005154419.2060504-1-yazen.ghannam@amd.com>
On Tue, Oct 05, 2021 at 03:44:19PM +0000, Yazen Ghannam wrote:
> AMD Rome systems and later support interleaving between three identical
> ranks within a channel.
>
> Check for this mode by counting the number of enabled chip selects and
> comparing their masks. If there are exactly three enabled chip selects
> and their masks are identical, then three rank interleaving is enabled.
>
> The size of a rank is determined from its mask value. However, three
> rank interleaving doesn't follow the method of swapping an interleave
> bit with the most significant bit. Rather, the interleave bit is flipped
> and the most significant bit remains the same. There is only a single
> interleave bit in this case.
>
> Account for this when determining the chip select size by keeping the
> most significant bit at its original value and ignoring any zero bits.
> This will return a full bitmask in [MSB:1].
>
> Fixes: e53a3b267fb0 ("EDAC/amd64: Find Chip Select memory size using Address Mask")
>
> Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
> ---
> drivers/edac/amd64_edac.c | 22 +++++++++++++++++++++-
> 1 file changed, 21 insertions(+), 1 deletion(-)
Applied, thanks.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2021-10-07 10:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 15:44 [PATCH] EDAC/amd64: Handle three rank interleaving mode Yazen Ghannam
2021-10-07 10:57 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YV7SpRD3b0eRkXcQ@zn.tnic \
--to=bp@alien8.de \
--cc=Smita.KoralahalliChannabasappa@amd.com \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox