From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C522C433F5 for ; Thu, 7 Oct 2021 17:20:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 149096113E for ; Thu, 7 Oct 2021 17:20:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243342AbhJGRWS (ORCPT ); Thu, 7 Oct 2021 13:22:18 -0400 Received: from mga04.intel.com ([192.55.52.120]:59828 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243315AbhJGRWD (ORCPT ); Thu, 7 Oct 2021 13:22:03 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10130"; a="225087853" X-IronPort-AV: E=Sophos;i="5.85,355,1624345200"; d="scan'208";a="225087853" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2021 10:20:08 -0700 X-IronPort-AV: E=Sophos;i="5.85,355,1624345200"; d="scan'208";a="522677255" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2021 10:20:03 -0700 Received: from andy by smile with local (Exim 4.95) (envelope-from ) id 1mYX3m-009bza-In; Thu, 07 Oct 2021 20:19:58 +0300 Date: Thu, 7 Oct 2021 20:19:58 +0300 From: Andy Shevchenko To: Joe Perches Cc: Brendan Higgins , Peter Zijlstra , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-media@vger.kernel.org, Ingo Molnar , Will Deacon , Waiman Long , Boqun Feng , Sakari Ailus , Laurent Pinchart , Mauro Carvalho Chehab , Andrew Morton , Miguel Ojeda , jic23@kernel.org, linux@rasmusvillemoes.dk, Thorsten Leemhuis Subject: Re: [PATCH v4 6/7] plist: Replace kernel.h with the necessary inclusions Message-ID: References: <20211007154407.29746-1-andriy.shevchenko@linux.intel.com> <20211007154407.29746-7-andriy.shevchenko@linux.intel.com> <1ec405c5a8fd24de9066277ce855d7e39f93e691.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1ec405c5a8fd24de9066277ce855d7e39f93e691.camel@perches.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 07, 2021 at 10:12:56AM -0700, Joe Perches wrote: > On Thu, 2021-10-07 at 18:44 +0300, Andy Shevchenko wrote: > > When kernel.h is used in the headers it adds a lot into dependency hell, > > especially when there are circular dependencies are involved. > > > > Replace kernel.h inclusion with the list of what is really being used. > [] > > diff --git a/include/linux/plist.h b/include/linux/plist.h > [] > > @@ -73,8 +73,11 @@ > [] > > +#include > > why asm/bug.h and not linux/bug.h ? The direct inclusion is from that one. Why linux/bug? What are we going to use from it? -- With Best Regards, Andy Shevchenko