public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: guolongji <guolongji@uniontech.com>
Cc: fabioaiuto83@gmail.com, ross.schm.dev@gmail.com,
	marcocesati@gmail.com, fmdefrancesco@gmail.com,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: remove meaningless pstat->passoc_req check in OnAssocReq()
Date: Sun, 26 Sep 2021 13:21:17 +0200	[thread overview]
Message-ID: <YVBXrQ2+cb3Tq8d7@kroah.com> (raw)
In-Reply-To: <20210926103014.30088-1-guolongji@uniontech.com>

On Sun, Sep 26, 2021 at 06:30:14PM +0800, guolongji wrote:
> kfree(NULL) is safe and the check 'if (pstat->passoc_req)' before kfree
> is not possible.
> 
> Signed-off-by: guolongji <guolongji@uniontech.com>

We need a "full" or "real" name here.  Do you really sign documents with
a lower-case "g" like this?  If so, great, just have to check.

thanks,

greg k-h

  parent reply	other threads:[~2021-09-26 11:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210926103014.30088-1-guolongji@uniontech.com>
2021-09-26 11:10 ` [PATCH] staging: rtl8723bs: remove meaningless pstat->passoc_req check in OnAssocReq() Fabio M. De Francesco
2021-09-26 11:21 ` Greg KH [this message]
     [not found] <20210927033056.27503-1-guolongji@uniontech.com>
2021-09-27  8:27 ` Hans de Goede
2021-09-27 15:24 ` Greg KH
     [not found] <20210927114925.15940-1-guolongji@uniontech.com>
2021-09-27 11:51 ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YVBXrQ2+cb3Tq8d7@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=fabioaiuto83@gmail.com \
    --cc=fmdefrancesco@gmail.com \
    --cc=guolongji@uniontech.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=marcocesati@gmail.com \
    --cc=ross.schm.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox