From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Tommaso Merciai <tomm.merciai@gmail.com>
Cc: "Forest Bond" <forest@alittletooquiet.net>,
"Lucas Henneman" <lucas.henneman@linaro.org>,
"Yujia Qiao" <rapiz@foxmail.com>,
"Madhumitha Prabakaran" <madhumithabiw@gmail.com>,
"Marcos Antonio de Jesus Filho" <mdejesusfilho@gmail.com>,
"Aldas Taraškevičius" <aldas60@gmail.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
"Deepak R Varma" <mh12gx2825@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/3] staging: vt6655: fix camelcase in bShortSlotTime
Date: Tue, 28 Sep 2021 06:43:00 +0200 [thread overview]
Message-ID: <YVKdVCaVwmPG7DVx@kroah.com> (raw)
In-Reply-To: <20210927213515.GA6953@tom-desktop>
On Mon, Sep 27, 2021 at 11:35:15PM +0200, Tommaso Merciai wrote:
> On Mon, Sep 27, 2021 at 05:26:14PM +0200, Greg Kroah-Hartman wrote:
> > On Sun, Sep 26, 2021 at 06:25:18PM +0200, Tommaso Merciai wrote:
> > > Replace camel case variable bShortSlotTime with snake case
> > > variable b_short_slot_time.
> >
> > That is a very odd variable name. Why did you pick that one?
> >
> > What deos it mean?
> >
> > You do understand where the original naming format came from here, and
> > what it was trying to represent, right? If not, please go read up on
> > it:
> > https://en.wikipedia.org/wiki/Hungarian_notation
> >
> > That style is not used in Linux, and so, when converting from it, do not
> > attempt to keep the same style present here, that is kind of pointless,
> > don't you agree?
>
> You are definitely right. What do you think about "short_slot_time"?
"time" implies that this will hold a value of time, right?
What exactly does this variable do? That might help in naming it
better.
thanks,
greg k-h
next prev parent reply other threads:[~2021-09-28 4:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-26 16:25 [PATCH v5 0/3] staging: vt6655: replace camel case variables Tommaso Merciai
2021-09-26 16:25 ` [PATCH v5 1/3] staging: vt6655: fix camelcase in bShortSlotTime Tommaso Merciai
2021-09-27 15:26 ` Greg Kroah-Hartman
2021-09-27 21:35 ` Tommaso Merciai
2021-09-28 4:43 ` Greg Kroah-Hartman [this message]
2021-09-30 21:49 ` Tommaso Merciai
2021-10-04 10:26 ` Dan Carpenter
2021-10-04 12:58 ` Tommaso Merciai
2021-10-04 13:15 ` Dan Carpenter
2021-10-04 17:30 ` Tommaso Merciai
2021-09-26 16:25 ` [PATCH v5 2/3] staging: vt6655: fix camelcase in ldBmThreshold Tommaso Merciai
2021-09-27 15:26 ` Greg Kroah-Hartman
2021-09-27 21:46 ` Tommaso Merciai
2021-09-28 4:42 ` Greg Kroah-Hartman
2021-09-29 12:56 ` Tommaso Merciai
2021-09-30 21:30 ` Tommaso Merciai
2021-09-26 16:25 ` [PATCH v5 3/3] staging: vt6655: fix camelcase in PortOffset Tommaso Merciai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVKdVCaVwmPG7DVx@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=aldas60@gmail.com \
--cc=forest@alittletooquiet.net \
--cc=gustavoars@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lucas.henneman@linaro.org \
--cc=madhumithabiw@gmail.com \
--cc=mdejesusfilho@gmail.com \
--cc=mh12gx2825@gmail.com \
--cc=rapiz@foxmail.com \
--cc=tomm.merciai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox