public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	linuxarm@huawei.com, mauro.chehab@huawei.com,
	Arnd Bergmann <arnd@arndb.de>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mfd: hi6421-spmi-pmic: cleanup drvdata
Date: Tue, 28 Sep 2021 11:09:12 +0200	[thread overview]
Message-ID: <YVLbuI6SXVPy2CQm@kroah.com> (raw)
In-Reply-To: <YVLI9sXN2R/IHSzq@google.com>

On Tue, Sep 28, 2021 at 08:49:10AM +0100, Lee Jones wrote:
> On Tue, 28 Sep 2021, Greg Kroah-Hartman wrote:
> 
> > On Tue, Sep 28, 2021 at 08:58:19AM +0200, Mauro Carvalho Chehab wrote:
> > > There are lots of fields in struct hi6421_spmi_pmic that aren't
> > > used. As a matter of fact, only regmap is needed.
> > > 
> > > So, drop the struct as a whole, and just set the regmap as
> > > the drvdata.
> > > 
> > > Acked-by: Mark Brown <broonie@kernel.org>
> > > Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
> > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> > 
> > As everyone else acked this, any objection for me to just take this in
> > my char-misc tree?
> > 
> > Otherwise, whoever else want to take it:
> > 
> > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> If you do end up taking it, you'll have to convert my Ack.
> 
> Although, I'm probably in a better position to take it TBH.
> 
> Happy with either.  You decide.

You can take it, thanks!

greg k-h

  reply	other threads:[~2021-09-28  9:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-02 12:47 [PATCH v2] mfd: hi6421-spmi-pmic: cleanup drvdata Mauro Carvalho Chehab
2021-09-22 13:23 ` Lee Jones
2021-09-28  6:58   ` Mauro Carvalho Chehab
2021-09-28  7:14     ` Greg Kroah-Hartman
2021-09-28  7:49       ` Lee Jones
2021-09-28  9:09         ` Greg Kroah-Hartman [this message]
2021-10-05  8:03 ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YVLbuI6SXVPy2CQm@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=mauro.chehab@huawei.com \
    --cc=mchehab+huawei@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox