From: Borislav Petkov <bp@suse.de>
To: unknown <weidonghui@allwinnertech.com>
Cc: akpm@linux-foundation.org, maz@misterjones.org, will@kernel.org,
rabin@rab.in, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] scripts/decodecode: fix faulting instruction no print when opps.file is DOS format
Date: Tue, 28 Sep 2021 11:19:17 +0200 [thread overview]
Message-ID: <YVLeFbrAMF7s1F0e@zn.tnic> (raw)
In-Reply-To: <20210928062316.3481-1-weidonghui@allwinnertech.com>
You forgot to CC a mailing list, lemme do that for you.
On Tue, Sep 28, 2021 at 02:23:16PM +0800, unknown wrote:
> From: weidonghui <weidonghui@allwinnertech.com>
>
> If opps.file is in DOS format, faulting instruction cannot be printed:
> / # ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu-
> / # ./scripts/decodecode < oops.file
> [ 0.734345] Code: d0002881 912f9c21 94067e68 d2800001 (b900003f)
> aarch64-linux-gnu-strip: '/tmp/tmp.5Y9eybnnSi.o': No such file
> aarch64-linux-gnu-objdump: '/tmp/tmp.5Y9eybnnSi.o': No such file
> All code
> ========
> 0: d0002881 adrp x1, 0x512000
> 4: 912f9c21 add x1, x1, #0xbe7
> 8: 94067e68 bl 0x19f9a8
> c: d2800001 mov x1, #0x0 // #0
> 10: b900003f str wzr, [x1]
>
> Code starting with the faulting instruction
> ===========================================
>
> Background: The compilation environment is Ubuntu,
> and the test environment is Windows.
> Most logs are generated in the Windows environment.
> In this way, CR (carriage return) will inevitably appear,
> which will affect the use of decodecode in the Ubuntu environment.
> The repaired effect is as follows:
> / # ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu-
> / # ./scripts/decodecode < oops.file
> [ 0.734345] Code: d0002881 912f9c21 94067e68 d2800001 (b900003f)
> All code
> ========
> 0: d0002881 adrp x1, 0x512000
> 4: 912f9c21 add x1, x1, #0xbe7
> 8: 94067e68 bl 0x19f9a8
> c: d2800001 mov x1, #0x0 // #0
> 10:* b900003f str wzr, [x1] <-- trapping instruction
>
> Code starting with the faulting instruction
> ===========================================
> 0: b900003f str wzr, [x1]
>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Cc: Marc Zyngier <maz@misterjones.org>
> Cc: Will Deacon <will@kernel.org>
> Cc: Rabin Vincent <rabin@rab.in>
> Signed-off-by: weidonghui <weidonghui@allwinnertech.com>
> ---
> scripts/decodecode | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/decodecode b/scripts/decodecode
> index 31d884e35f2f..8738f721a06c 100755
> --- a/scripts/decodecode
> +++ b/scripts/decodecode
> @@ -126,7 +126,7 @@ if [ $marker -ne 0 ]; then
> fi
> echo Code starting with the faulting instruction > $T.aa
> echo =========================================== >> $T.aa
> -code=`echo $code | sed -e 's/ [<(]/ /;s/[>)] / /;s/ /,0x/g; s/[>)]$//'`
> +code=`echo $code | tr -d "\\015" | sed -e 's/ [<(]/ /;s/[>)] / /;s/ /,0x/g; s/[>)]$//'`
^^^^^^^^^^^^^
Let me google this for you:
https://stackoverflow.com/questions/12167178/replace-windows-newlines-in-a-lot-of-files-using-sed-but-it-doesnt
> echo -n " .$type 0x" > $T.s
> echo $code >> $T.s
> disas $T 0
> --
> 2.22.0.windows.1
--
Regards/Gruss,
Boris.
SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
parent reply other threads:[~2021-09-28 9:19 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20210928062316.3481-1-weidonghui@allwinnertech.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVLeFbrAMF7s1F0e@zn.tnic \
--to=bp@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@misterjones.org \
--cc=rabin@rab.in \
--cc=weidonghui@allwinnertech.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox