* Re: [PATCH v2] scripts/decodecode: fix faulting instruction no print when opps.file is DOS format
[not found] <20210928062316.3481-1-weidonghui@allwinnertech.com>
@ 2021-09-28 9:19 ` Borislav Petkov
0 siblings, 0 replies; only message in thread
From: Borislav Petkov @ 2021-09-28 9:19 UTC (permalink / raw)
To: unknown; +Cc: akpm, maz, will, rabin, lkml
You forgot to CC a mailing list, lemme do that for you.
On Tue, Sep 28, 2021 at 02:23:16PM +0800, unknown wrote:
> From: weidonghui <weidonghui@allwinnertech.com>
>
> If opps.file is in DOS format, faulting instruction cannot be printed:
> / # ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu-
> / # ./scripts/decodecode < oops.file
> [ 0.734345] Code: d0002881 912f9c21 94067e68 d2800001 (b900003f)
> aarch64-linux-gnu-strip: '/tmp/tmp.5Y9eybnnSi.o': No such file
> aarch64-linux-gnu-objdump: '/tmp/tmp.5Y9eybnnSi.o': No such file
> All code
> ========
> 0: d0002881 adrp x1, 0x512000
> 4: 912f9c21 add x1, x1, #0xbe7
> 8: 94067e68 bl 0x19f9a8
> c: d2800001 mov x1, #0x0 // #0
> 10: b900003f str wzr, [x1]
>
> Code starting with the faulting instruction
> ===========================================
>
> Background: The compilation environment is Ubuntu,
> and the test environment is Windows.
> Most logs are generated in the Windows environment.
> In this way, CR (carriage return) will inevitably appear,
> which will affect the use of decodecode in the Ubuntu environment.
> The repaired effect is as follows:
> / # ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu-
> / # ./scripts/decodecode < oops.file
> [ 0.734345] Code: d0002881 912f9c21 94067e68 d2800001 (b900003f)
> All code
> ========
> 0: d0002881 adrp x1, 0x512000
> 4: 912f9c21 add x1, x1, #0xbe7
> 8: 94067e68 bl 0x19f9a8
> c: d2800001 mov x1, #0x0 // #0
> 10:* b900003f str wzr, [x1] <-- trapping instruction
>
> Code starting with the faulting instruction
> ===========================================
> 0: b900003f str wzr, [x1]
>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Cc: Marc Zyngier <maz@misterjones.org>
> Cc: Will Deacon <will@kernel.org>
> Cc: Rabin Vincent <rabin@rab.in>
> Signed-off-by: weidonghui <weidonghui@allwinnertech.com>
> ---
> scripts/decodecode | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/decodecode b/scripts/decodecode
> index 31d884e35f2f..8738f721a06c 100755
> --- a/scripts/decodecode
> +++ b/scripts/decodecode
> @@ -126,7 +126,7 @@ if [ $marker -ne 0 ]; then
> fi
> echo Code starting with the faulting instruction > $T.aa
> echo =========================================== >> $T.aa
> -code=`echo $code | sed -e 's/ [<(]/ /;s/[>)] / /;s/ /,0x/g; s/[>)]$//'`
> +code=`echo $code | tr -d "\\015" | sed -e 's/ [<(]/ /;s/[>)] / /;s/ /,0x/g; s/[>)]$//'`
^^^^^^^^^^^^^
Let me google this for you:
https://stackoverflow.com/questions/12167178/replace-windows-newlines-in-a-lot-of-files-using-sed-but-it-doesnt
> echo -n " .$type 0x" > $T.s
> echo $code >> $T.s
> disas $T 0
> --
> 2.22.0.windows.1
--
Regards/Gruss,
Boris.
SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
^ permalink raw reply [flat|nested] only message in thread