From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94363C433FE for ; Tue, 28 Sep 2021 12:00:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 78E8761157 for ; Tue, 28 Sep 2021 12:00:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240530AbhI1MCP (ORCPT ); Tue, 28 Sep 2021 08:02:15 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:35794 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240514AbhI1MCN (ORCPT ); Tue, 28 Sep 2021 08:02:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=THuN358noEt3fQeP4VpcOCHPfZXYMNW8DrJloNvgVT4=; b=VY a6LHE1sW7G1eFvRUjwZiG3qkChUCGCFYwOzGXtr7i7sYHT4ckwvfKnHl48Det0NXQOBID8RvSGZUv We/3H8RYUkLjXRizmD04E5uQtCc/k636NYVscmrFtj0A3dP+gswxmw2hUJ95wG0BIPwAynXDWidwg htw5iTtEOOIG/Js=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mVBmO-008b4G-MV; Tue, 28 Sep 2021 14:00:12 +0200 Date: Tue, 28 Sep 2021 14:00:12 +0200 From: Andrew Lunn To: Cai Huoqing Cc: Horatiu Vultur , hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: mdio: mscc-miim: Fix the mdio controller Message-ID: References: <20210928071720.2084666-1-horatiu.vultur@microchip.com> <20210928085414.GA1723@LAPTOP-UKSR4ENP.internal.baidu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210928085414.GA1723@LAPTOP-UKSR4ENP.internal.baidu.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 28, 2021 at 04:54:14PM +0800, Cai Huoqing wrote: > On 28 9月 21 09:17:20, Horatiu Vultur wrote: > Hi Horatiu, > > Thank for your feedback. > > I'm sorry for this commit, my mistake. > > After I have checked my recent submission history > > the commit- > commit fa14d03e014a130839f9dc1b97ea61fe598d873d > drivers/net/mdio/mdio-ipq4019.c 225 line > > has the same issue, an optional phy-regs > Are you willing to fix it at the same time:) Hi Since it was a separate patch which broken it, it should be a separate patch which fixes it. Please send a fix. You can also give a Reviewed-by: to Horatiu patch, if you think it is correct. Andrew