Re: [PATCH 02/10] i2c: pasemi: Use io{read,write}32

Sven Peter
2021-09-28T15:49:10Z

On Mon, Sep 27, 2021, at 09:39, Arnd Bergmann wrote:
> On Sun, Sep 26, 2021 at 12:00 PM Sven Peter <sven@svenpeter.dev> wrote:
>>
>> In preparation for splitting this driver up into a platform_driver
>> and a pci_driver, replace outl/inl usage with ioport_map and
>> ioread32/iowrite32.
>>
>> Signed-off-by: Sven Peter <sven@svenpeter.dev>
>>
>> + smbus->ioaddr = ioport_map(smbus->base, smbus->size);
>> + if (!smbus->ioaddr) {
>> + error = -EBUSY;
>> + goto out_release_region;
>> + }
>
> While this works, I would suggest using the more regular pci_iomap()
> or pcim_iomap() helper to turn the port number into an __iomem token.

Thanks a lot for the review!

I'll replace it with pci_iomap here and then later in this series with
pcim_iomap when also switching the rest to devres.

Thanks,

Sven