From: "Krzysztof Wilczyński" <kw@linux.com>
To: Max Gurtovoy <mgurtovoy@nvidia.com>
Cc: hch@infradead.org, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org, stefanha@redhat.com, oren@nvidia.com,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/1] driver core: use NUMA_NO_NODE during device_initialize
Date: Thu, 30 Sep 2021 16:41:13 +0200 [thread overview]
Message-ID: <YVXMifT1hdIci1cp@rocinante> (raw)
In-Reply-To: <20210930142556.9999-1-mgurtovoy@nvidia.com>
Hi Max,
> Don't use (-1) constant for setting initial device node. Instead, use
> the generic NUMA_NO_NODE definition to indicate that "no node id
> specified".
>
> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> ---
> drivers/base/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index e65dd803a453..2b4b46f6c676 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -2838,7 +2838,7 @@ void device_initialize(struct device *dev)
> spin_lock_init(&dev->devres_lock);
> INIT_LIST_HEAD(&dev->devres_head);
> device_pm_init(dev);
> - set_dev_node(dev, -1);
> + set_dev_node(dev, NUMA_NO_NODE);
We might have one of these to fix in the PCI tree, as per:
https://elixir.bootlin.com/linux/v5.15-rc3/source/drivers/pci/pci-sysfs.c#L84
Would this be of interest to you for a potential v2?
Krzysztof
next prev parent reply other threads:[~2021-09-30 14:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 14:25 [PATCH 1/1] driver core: use NUMA_NO_NODE during device_initialize Max Gurtovoy
2021-09-30 14:41 ` Krzysztof Wilczyński [this message]
2021-09-30 14:51 ` Max Gurtovoy
2021-09-30 15:30 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVXMifT1hdIci1cp@rocinante \
--to=kw@linux.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mgurtovoy@nvidia.com \
--cc=oren@nvidia.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox