* [PATCH 1/1] driver core: use NUMA_NO_NODE during device_initialize
@ 2021-09-30 14:25 Max Gurtovoy
2021-09-30 14:41 ` Krzysztof Wilczyński
2021-09-30 15:30 ` Stefan Hajnoczi
0 siblings, 2 replies; 4+ messages in thread
From: Max Gurtovoy @ 2021-09-30 14:25 UTC (permalink / raw)
To: hch, linux-kernel, gregkh; +Cc: stefanha, oren, linux-pci, Max Gurtovoy
Don't use (-1) constant for setting initial device node. Instead, use
the generic NUMA_NO_NODE definition to indicate that "no node id
specified".
Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
---
drivers/base/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/core.c b/drivers/base/core.c
index e65dd803a453..2b4b46f6c676 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -2838,7 +2838,7 @@ void device_initialize(struct device *dev)
spin_lock_init(&dev->devres_lock);
INIT_LIST_HEAD(&dev->devres_head);
device_pm_init(dev);
- set_dev_node(dev, -1);
+ set_dev_node(dev, NUMA_NO_NODE);
#ifdef CONFIG_GENERIC_MSI_IRQ
raw_spin_lock_init(&dev->msi_lock);
INIT_LIST_HEAD(&dev->msi_list);
--
2.18.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] driver core: use NUMA_NO_NODE during device_initialize
2021-09-30 14:25 [PATCH 1/1] driver core: use NUMA_NO_NODE during device_initialize Max Gurtovoy
@ 2021-09-30 14:41 ` Krzysztof Wilczyński
2021-09-30 14:51 ` Max Gurtovoy
2021-09-30 15:30 ` Stefan Hajnoczi
1 sibling, 1 reply; 4+ messages in thread
From: Krzysztof Wilczyński @ 2021-09-30 14:41 UTC (permalink / raw)
To: Max Gurtovoy; +Cc: hch, linux-kernel, gregkh, stefanha, oren, linux-pci
Hi Max,
> Don't use (-1) constant for setting initial device node. Instead, use
> the generic NUMA_NO_NODE definition to indicate that "no node id
> specified".
>
> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> ---
> drivers/base/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index e65dd803a453..2b4b46f6c676 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -2838,7 +2838,7 @@ void device_initialize(struct device *dev)
> spin_lock_init(&dev->devres_lock);
> INIT_LIST_HEAD(&dev->devres_head);
> device_pm_init(dev);
> - set_dev_node(dev, -1);
> + set_dev_node(dev, NUMA_NO_NODE);
We might have one of these to fix in the PCI tree, as per:
https://elixir.bootlin.com/linux/v5.15-rc3/source/drivers/pci/pci-sysfs.c#L84
Would this be of interest to you for a potential v2?
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] driver core: use NUMA_NO_NODE during device_initialize
2021-09-30 14:41 ` Krzysztof Wilczyński
@ 2021-09-30 14:51 ` Max Gurtovoy
0 siblings, 0 replies; 4+ messages in thread
From: Max Gurtovoy @ 2021-09-30 14:51 UTC (permalink / raw)
To: Krzysztof Wilczyński
Cc: hch, linux-kernel, gregkh, stefanha, oren, linux-pci
On 9/30/2021 5:41 PM, Krzysztof Wilczyński wrote:
> Hi Max,
>
>> Don't use (-1) constant for setting initial device node. Instead, use
>> the generic NUMA_NO_NODE definition to indicate that "no node id
>> specified".
>>
>> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
>> ---
>> drivers/base/core.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/base/core.c b/drivers/base/core.c
>> index e65dd803a453..2b4b46f6c676 100644
>> --- a/drivers/base/core.c
>> +++ b/drivers/base/core.c
>> @@ -2838,7 +2838,7 @@ void device_initialize(struct device *dev)
>> spin_lock_init(&dev->devres_lock);
>> INIT_LIST_HEAD(&dev->devres_head);
>> device_pm_init(dev);
>> - set_dev_node(dev, -1);
>> + set_dev_node(dev, NUMA_NO_NODE);
> We might have one of these to fix in the PCI tree, as per:
>
> https://elixir.bootlin.com/linux/v5.15-rc3/source/drivers/pci/pci-sysfs.c#L84
>
> Would this be of interest to you for a potential v2?
sure no problem. Lets get some reviews first and then I'll send v2 with
this patch as well.
> Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] driver core: use NUMA_NO_NODE during device_initialize
2021-09-30 14:25 [PATCH 1/1] driver core: use NUMA_NO_NODE during device_initialize Max Gurtovoy
2021-09-30 14:41 ` Krzysztof Wilczyński
@ 2021-09-30 15:30 ` Stefan Hajnoczi
1 sibling, 0 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2021-09-30 15:30 UTC (permalink / raw)
To: Max Gurtovoy; +Cc: hch, linux-kernel, gregkh, oren, linux-pci
[-- Attachment #1: Type: text/plain, Size: 430 bytes --]
On Thu, Sep 30, 2021 at 05:25:56PM +0300, Max Gurtovoy wrote:
> Don't use (-1) constant for setting initial device node. Instead, use
> the generic NUMA_NO_NODE definition to indicate that "no node id
> specified".
>
> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> ---
> drivers/base/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks!
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-30 15:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-30 14:25 [PATCH 1/1] driver core: use NUMA_NO_NODE during device_initialize Max Gurtovoy
2021-09-30 14:41 ` Krzysztof Wilczyński
2021-09-30 14:51 ` Max Gurtovoy
2021-09-30 15:30 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox