* [PATCH] fs: 9p: cache.h: cleanup some format warning
@ 2021-09-30 21:24 Sohaib Mohamed
2021-09-30 23:00 ` Dominique Martinet
0 siblings, 1 reply; 2+ messages in thread
From: Sohaib Mohamed @ 2021-09-30 21:24 UTC (permalink / raw)
Cc: Sohaib Mohamed, Eric Van Hensbergen, Latchesar Ionkov,
Dominique Martinet, v9fs-developer, linux-kernel
Warnings found by checkpatch.pl
Signed-off-by: Sohaib Mohamed <sohaib.amhmd@gmail.com>
---
fs/9p/cache.h | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/fs/9p/cache.h b/fs/9p/cache.h
index 00f107af443e..14fd222352f3 100644
--- a/fs/9p/cache.h
+++ b/fs/9p/cache.h
@@ -34,7 +34,7 @@ extern int __v9fs_readpage_from_fscache(struct inode *inode,
extern int __v9fs_readpages_from_fscache(struct inode *inode,
struct address_space *mapping,
struct list_head *pages,
- unsigned *nr_pages);
+ unsigned int *nr_pages);
extern void __v9fs_readpage_to_fscache(struct inode *inode, struct page *page);
extern void __v9fs_fscache_wait_on_page_write(struct inode *inode,
struct page *page);
@@ -59,7 +59,7 @@ static inline int v9fs_readpage_from_fscache(struct inode *inode,
static inline int v9fs_readpages_from_fscache(struct inode *inode,
struct address_space *mapping,
struct list_head *pages,
- unsigned *nr_pages)
+ unsigned int *nr_pages)
{
return __v9fs_readpages_from_fscache(inode, mapping, pages,
nr_pages);
@@ -75,6 +75,7 @@ static inline void v9fs_readpage_to_fscache(struct inode *inode,
static inline void v9fs_uncache_page(struct inode *inode, struct page *page)
{
struct v9fs_inode *v9inode = V9FS_I(inode);
+
fscache_uncache_page(v9inode->fscache, page);
BUG_ON(PageFsCache(page));
}
@@ -115,7 +116,7 @@ static inline int v9fs_readpage_from_fscache(struct inode *inode,
static inline int v9fs_readpages_from_fscache(struct inode *inode,
struct address_space *mapping,
struct list_head *pages,
- unsigned *nr_pages)
+ unsigned int *nr_pages)
{
return -ENOBUFS;
}
@@ -129,9 +130,7 @@ static inline void v9fs_uncache_page(struct inode *inode, struct page *page)
static inline void v9fs_fscache_wait_on_page_write(struct inode *inode,
struct page *page)
-{
- return;
-}
+{}
#endif /* CONFIG_9P_FSCACHE */
#endif /* _9P_CACHE_H */
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fs: 9p: cache.h: cleanup some format warning
2021-09-30 21:24 [PATCH] fs: 9p: cache.h: cleanup some format warning Sohaib Mohamed
@ 2021-09-30 23:00 ` Dominique Martinet
0 siblings, 0 replies; 2+ messages in thread
From: Dominique Martinet @ 2021-09-30 23:00 UTC (permalink / raw)
To: Sohaib Mohamed
Cc: Eric Van Hensbergen, Latchesar Ionkov, v9fs-developer,
linux-kernel
Sohaib Mohamed wrote on Thu, Sep 30, 2021 at 11:24:54PM +0200:
> Warnings found by checkpatch.pl
All this code is gone in linux-next (fscache work), so skipping this
patch.
The other patch is good, I'll take it tonight/this weekend - thanks for
the cleanups!
--
Dominique
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-30 23:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-30 21:24 [PATCH] fs: 9p: cache.h: cleanup some format warning Sohaib Mohamed
2021-09-30 23:00 ` Dominique Martinet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox