From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57C24C433EF for ; Fri, 1 Oct 2021 13:15:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3DA7361A54 for ; Fri, 1 Oct 2021 13:15:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231557AbhJANRh (ORCPT ); Fri, 1 Oct 2021 09:17:37 -0400 Received: from mga12.intel.com ([192.55.52.136]:18894 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230422AbhJANRf (ORCPT ); Fri, 1 Oct 2021 09:17:35 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10123"; a="204914574" X-IronPort-AV: E=Sophos;i="5.85,339,1624345200"; d="scan'208";a="204914574" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2021 06:15:50 -0700 X-IronPort-AV: E=Sophos;i="5.85,339,1624345200"; d="scan'208";a="480445958" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2021 06:15:47 -0700 Received: from andy by smile with local (Exim 4.95-RC2) (envelope-from ) id 1mWIO8-007Ru3-G6; Fri, 01 Oct 2021 16:15:44 +0300 Date: Fri, 1 Oct 2021 16:15:44 +0300 From: Andy Shevchenko To: Greg Kroah-Hartman Cc: Tomas Winkler , Alexander Usyskin , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Arnd Bergmann , Christoph Hellwig , Masahiro Yamada , Michal Marek , Nick Desaulniers Subject: Re: [PATCH v3 2/4] uuid: Make guid_t completely internal type to the kernel Message-ID: References: <20211001113747.64040-1-andriy.shevchenko@linux.intel.com> <20211001113747.64040-2-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 01, 2021 at 02:01:15PM +0200, Greg Kroah-Hartman wrote: > On Fri, Oct 01, 2021 at 02:37:45PM +0300, Andy Shevchenko wrote: > > The guid_t type was defined in UAPI by mistake. > > Keep it an internal type and leave uuid_le UAPI > > for it's only user, i.e. MEI. > > It's used in they hyper-v drivers as a uapi between the kernel and the > hypervisor, so isn't that something valid here? I'm not sure I see that interface defined in the kernel. As far as I remember the guid_t is used solely inside kernel by Hyper-V code and the rest is using raw buffers. Can you point out to the specific place(s)? > As I didn't see a 0/4 for this series, I'm confused as to your end-goal > here. What are you trying to do with this series? End goal is to decouple internal type, which is guid_t, from ABI, where should be something else in use, like __u8[16] or so. We have two internal types, i.e. uuid_t and guid_t that are differs by byte ordering (when represented as human-readable string). uuid_t is provided by libuuid in the user space and its definition may be quite different to what we have inside kernel. Kernel already hide that one. guid_t is a leftover. I will create a cover letter for next version. -- With Best Regards, Andy Shevchenko