From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DDBDC433F5 for ; Fri, 1 Oct 2021 19:32:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0E04E61A02 for ; Fri, 1 Oct 2021 19:32:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355289AbhJATel (ORCPT ); Fri, 1 Oct 2021 15:34:41 -0400 Received: from mga01.intel.com ([192.55.52.88]:53733 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229966AbhJATek (ORCPT ); Fri, 1 Oct 2021 15:34:40 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10124"; a="248118277" X-IronPort-AV: E=Sophos;i="5.85,340,1624345200"; d="scan'208";a="248118277" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2021 12:32:55 -0700 X-IronPort-AV: E=Sophos;i="5.85,340,1624345200"; d="scan'208";a="619359793" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2021 12:32:53 -0700 Received: from andy by smile with local (Exim 4.95-RC2) (envelope-from ) id 1mWOH4-007WhY-BC; Fri, 01 Oct 2021 22:32:50 +0300 Date: Fri, 1 Oct 2021 22:32:50 +0300 From: Andy Shevchenko To: Jakub Kicinski Cc: "David S. Miller" , Lee Jones , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Richard Cochran Subject: Re: [PATCH v1 net 1/1] ptp_pch: Load module automatically if ID matches Message-ID: References: <20211001162033.13578-1-andriy.shevchenko@linux.intel.com> <20211001121109.64aaac57@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211001121109.64aaac57@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 01, 2021 at 12:11:09PM -0700, Jakub Kicinski wrote: > On Fri, 1 Oct 2021 19:20:33 +0300 Andy Shevchenko wrote: > > The driver can't be loaded automatically because it misses > > module alias to be provided. Add corresponding MODULE_DEVICE_TABLE() > > call to the driver. > > > > Signed-off-by: Andy Shevchenko > > Could you reply with a Fixes tag? (no need to resend, I think) Fixes: 863d08ece9bf ("supports eg20t ptp clock") -- With Best Regards, Andy Shevchenko