* [PATCH] staging: rtl8723bs: core: remove reassignment of same value to variable
@ 2021-10-03 16:18 Saurav Girepunje
2021-10-04 8:04 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Saurav Girepunje @ 2021-10-03 16:18 UTC (permalink / raw)
To: gregkh, fabioaiuto83, ross.schm.dev, hdegoede, marcocesati,
fmdefrancesco, linux-staging, linux-kernel
Cc: saurav.girepunje
Remove reassignment of same value to variable pstat->auth_seq.
On if (seq == 1) assigning the value 2. At the end of if statement
also assigning the value pstat->auth_seq = seq + 1 that is again
assigning the value 2.
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
index 3ee4d35ca8d7..059cd85f4b03 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
@@ -808,7 +808,6 @@ unsigned int OnAuth(struct adapter *padapter, union recv_frame *precv_frame)
pstat->state &= ~WIFI_FW_AUTH_NULL;
pstat->state |= WIFI_FW_AUTH_STATE;
pstat->authalg = algorithm;
- pstat->auth_seq = 2;
} else if (seq == 3) {
p = rtw_get_ie(pframe + WLAN_HDR_A3_LEN + 4 + _AUTH_IE_OFFSET_, WLAN_EID_CHALLENGE, (int *)&ie_len,
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: rtl8723bs: core: remove reassignment of same value to variable
2021-10-03 16:18 [PATCH] staging: rtl8723bs: core: remove reassignment of same value to variable Saurav Girepunje
@ 2021-10-04 8:04 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2021-10-04 8:04 UTC (permalink / raw)
To: Saurav Girepunje, gregkh, fabioaiuto83, ross.schm.dev,
marcocesati, fmdefrancesco, linux-staging, linux-kernel
Cc: saurav.girepunje
Hi,
On 10/3/21 6:18 PM, Saurav Girepunje wrote:
> Remove reassignment of same value to variable pstat->auth_seq.
> On if (seq == 1) assigning the value 2. At the end of if statement
> also assigning the value pstat->auth_seq = seq + 1 that is again
> assigning the value 2.
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> index 3ee4d35ca8d7..059cd85f4b03 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> @@ -808,7 +808,6 @@ unsigned int OnAuth(struct adapter *padapter, union recv_frame *precv_frame)
> pstat->state &= ~WIFI_FW_AUTH_NULL;
> pstat->state |= WIFI_FW_AUTH_STATE;
> pstat->authalg = algorithm;
> - pstat->auth_seq = 2;
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> } else if (seq == 3) {
>
> p = rtw_get_ie(pframe + WLAN_HDR_A3_LEN + 4 + _AUTH_IE_OFFSET_, WLAN_EID_CHALLENGE, (int *)&ie_len,
> --
> 2.32.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-04 8:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-03 16:18 [PATCH] staging: rtl8723bs: core: remove reassignment of same value to variable Saurav Girepunje
2021-10-04 8:04 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox