From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Marek Behún" <kabel@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>, Pavel Machek <pavel@ucw.cz>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
netdev@vger.kernel.org,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: are device names part of sysfs ABI? (was Re: devicename part of LEDs under ethernet MAC / PHY)
Date: Mon, 4 Oct 2021 08:37:37 +0200 [thread overview]
Message-ID: <YVqhMeuDI0IZL/zY@kroah.com> (raw)
In-Reply-To: <20211003225338.76092ec3@thinkpad>
On Sun, Oct 03, 2021 at 10:53:38PM +0200, Marek Behún wrote:
> Hello Greg,
>
> could you give your opinion on this discussion?
What discussion? Top posting ruins that :(
> Are device names (as returned by dev_name() function) also part of
> sysfs ABI? Should these names be stable across reboots / kernel
> upgrades?
Stable in what exact way?
Numbering of devices (where a dynamic value is part of a name, like the
"42" in "usb42"), is never guaranteed to be stable, but the non-number
part of the name (like "usb" is in "usb42") is stable, as that is what
you have properly documented in the Documentation/ABI/ files defining
the bus and class devices, right?
The very reason we export all of this information to userspace is so
that userspace can figure it all out in ways it wants to, if it wants
to, and no naming scheme that has to be static and deterministic is
forced into the kernel, where it does NOT belong.
That is 1/2 of the reason why we created the whole "unified
device/driver model" in the kernel in the first place all those years
ago.
Does that help? I can't figure out what the "problem" is here...
thanks,
greg k-h
next prev parent reply other threads:[~2021-10-04 6:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211001133057.5287f150@thinkpad>
[not found] ` <YVb/HSLqcOM6drr1@lunn.ch>
[not found] ` <20211001144053.3952474a@thinkpad>
2021-10-03 20:53 ` are device names part of sysfs ABI? (was Re: devicename part of LEDs under ethernet MAC / PHY) Marek Behún
2021-10-04 6:37 ` Greg Kroah-Hartman [this message]
2021-10-04 7:04 ` Marek Behún
2021-10-04 7:10 ` Greg Kroah-Hartman
2021-10-04 7:25 ` Marek Behún
2021-10-04 7:38 ` Pavel Machek
2021-10-04 8:30 ` Greg Kroah-Hartman
2021-10-04 12:14 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVqhMeuDI0IZL/zY@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andrew@lunn.ch \
--cc=jacek.anaszewski@gmail.com \
--cc=kabel@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox