From: Lee Jones <lee.jones@linaro.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Orlando Chamberlain <redecorating@protonmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: intel-lpss: Add support for MacBookPro16,2 UART
Date: Mon, 4 Oct 2021 08:16:39 +0100 [thread overview]
Message-ID: <YVqqV2xIybMCVbmR@google.com> (raw)
In-Reply-To: <YVdR4bdpr9/E+GNf@smile.fi.intel.com>
On Fri, 01 Oct 2021, Andy Shevchenko wrote:
> On Fri, Oct 01, 2021 at 07:14:12PM +0100, Lee Jones wrote:
> > On Fri, 01 Oct 2021, Andy Shevchenko wrote:
> > > On Fri, Oct 01, 2021 at 08:51:46AM +0000, Orlando Chamberlain wrote:
>
> ...
>
> > > > + /* MacBookPro16,2 */
> > >
> > > Use
> > >
> > > /* ICL-N */
> > >
> > > here.
> >
> > Why is that?
>
> It's a standard way of representing PCH/SoC in the comments in this driver:
> - MacBookPro16,2 is not a name of the PCH/SoC
> - MacBookPro16,2 is possible not the solely hardware of this chip
Okay, that's fine.
> Why not to mention this name in the commit message?
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-10-04 7:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 8:51 [PATCH] mfd: intel-lpss: Add support for MacBookPro16,2 UART Orlando Chamberlain
2021-10-01 10:16 ` Andy Shevchenko
2021-10-01 10:40 ` [PATCHv2] " Orlando Chamberlain
2021-10-01 11:04 ` Andy Shevchenko
2021-10-01 18:14 ` [PATCH] " Lee Jones
2021-10-01 18:22 ` Andy Shevchenko
2021-10-02 3:31 ` [PATCHv3] mfd: intel-lpss: Add support for MacBookPro16,2 ICL-N UART Orlando Chamberlain
2021-10-02 11:04 ` Andy Shevchenko
2021-10-02 11:12 ` Orlando Chamberlain
2021-10-02 12:07 ` Andy Shevchenko
2021-10-04 6:53 ` Lee Jones
2021-10-04 7:16 ` Lee Jones [this message]
2021-10-02 11:16 ` [PATCHv4] " Orlando Chamberlain
2021-10-04 7:17 ` Lee Jones
2021-10-04 15:58 ` Aditya Garg
2021-10-04 16:10 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVqqV2xIybMCVbmR@google.com \
--to=lee.jones@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=redecorating@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox