Re: [PATCH V0 1/7] dt-bindings: connector: Add property for eud type c connector

Rob Herring
2021-10-04T16:37:20Z

On Mon, Oct 04, 2021 at 04:46:19PM +0530, Souradeep Chowdhury wrote:
> Added the property for EUD(Embedded USB Debug) connector.Added
> the "reg" and "interrupts" property which is needed for EUD.

You are going to need a better explanation of this h/w.

>
> Signed-off-by: Souradeep Chowdhury <schowdhu@codeaurora.org>
> ---
> .../devicetree/bindings/connector/usb-connector.yaml | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> index 7eb8659..908129f 100644
> --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml
> +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> @@ -30,6 +30,21 @@ properties:
> - const: samsung,usb-connector-11pin
> - const: usb-b-connector
>
> + - items:
> + - enum:
> + - qcom,sc7280-usb-connector-eud
> + - const: qcom,usb-connector-eud
> + - const: usb-c-connector
> +
> + reg:
> + items:
> + - description: EUD Base Register Region
> + - description: EUD Mode Manager Region

A connector node represents the physical connector on a board. That
can't really be an MMIO peripheral. Maybe you need a node for EUD and
then it should have a connector child node? Don't really know without
understanding this h/w.

> +
> + interrupts:
> + description:
> + EUD interrupt
> +
> label:
> description: Symbolic name for the connector.
>
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>
>