Re: [PATCH V0 4/7] usb: common: eud: Added the driver support for Embedded USB Debugger(EUD)

schowdhu
2021-10-05T14:00:21Z

On 2021-10-05 12:44, Joe Perches wrote:
> On Mon, 2021-10-04 at 09:42 -0700, Bjorn Andersson wrote:
>> On Mon 04 Oct 04:16 PDT 2021, Souradeep Chowdhury wrote:
>>
>> > Add support for control peripheral of EUD (Embedded USB Debugger) to
>> > listen to events such as USB attach/detach, pet EUD to indicate software
>> > is functional.Reusing the platform device kobj, sysfs entry 'enable' is
>> > created to enable or disable EUD.
> []
>> > diff --git a/drivers/usb/common/qcom_eud.c b/drivers/usb/common/qcom_eud.c
> []
>> > +static ssize_t enable_show(struct device *dev,
>> > + struct device_attribute *attr, char *buf)
>> > +{
>> > + struct eud_chip *chip = dev_get_drvdata(dev);
>> > +
>> > + return sprintf(buf, "%d", chip->enable);
>
> trivia:
>
> should probably use sysfs_emit and have a trailing '\n' in the format.

Ack