Re: [PATCH V0 3/7] usb: dwc3: drd: Register the eud connector child node for dwc3

kernel test robot
2021-10-05T04:43:36Z

[-- Attachment #1: Type: text/plain, Size: 2642 bytes --]

Hi Souradeep,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on usb/usb-testing]
[also build test WARNING on robh/for-next linus/master v5.15-rc3 next-20210922]
[cannot apply to balbi-usb/testing/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Souradeep-Chowdhury/Add-Embedded-USB-Debugger-EUD-driver/20211004-191901
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: i386-randconfig-a004-20211004 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project c0039de2953d15815448b4b3c3bafb45607781e0)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/4f53df1d9b6786f951384f59e3ffa7fed1817a2d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Souradeep-Chowdhury/Add-Embedded-USB-Debugger-EUD-driver/20211004-191901
git checkout 4f53df1d9b6786f951384f59e3ffa7fed1817a2d
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=i386

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/usb/dwc3/drd.c:171:47: warning: variable 'con_np' set but not used [-Wunused-but-set-variable]
struct device_node *np = dev->of_node, *con_np;
^
1 warning generated.

vim +/con_np +171 drivers/usb/dwc3/drd.c

167
168 static int dwc3_register_eud(struct dwc3 *dwc)
169 {
170 struct device *dev = dwc->dev;
> 171 struct device_node *np = dev->of_node, *con_np;
172 int ret;
173
174 con_np = of_get_child_by_name(np, "eud_usb_connector");
175 if (!np) {
176 dev_dbg(dev, "no usb_connector child node specified\n");
177 return 0;
178 }
179
180 ret = of_platform_populate(np, NULL, NULL, dev);
181 if (ret) {
182 dev_err(dev, "failed to register usb_connector - %d\n", ret);
183 return ret;
184 }
185
186 return 0;
187 }
188

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32125 bytes --]