From: "Krzysztof Wilczyński" <kw@linux.com>
To: Max Gurtovoy <mgurtovoy@nvidia.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
gregkh@linuxfoundation.org, hch@infradead.org,
stefanha@redhat.com, oren@nvidia.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] PCI/sysfs: use NUMA_NO_NODE macro
Date: Mon, 4 Oct 2021 21:07:30 +0200 [thread overview]
Message-ID: <YVtQ8ummGgG9AOZE@rocinante> (raw)
In-Reply-To: <YVpctu416oj5gZ2i@rocinante>
Hi Max,
[...]
> > #ifdef CONFIG_NUMA
> > - mask = (dev_to_node(dev) == -1) ? cpu_online_mask :
> > - cpumask_of_node(dev_to_node(dev));
> > + mask = (dev_to_node(dev) == NUMA_NO_NODE) ? cpu_online_mask :
> > + cpumask_of_node(dev_to_node(dev));
>
> Oh this somewhat awkward indentation we have with this ternary now,
> and so I wonder if either:
>
> mask = (dev_to_node(dev) == NUMA_NO_NODE) ?
> cpu_online_mask : cpumask_of_node(dev_to_node(dev));
>
> Or, perhaps (yes, a few more lines):
>
> if (dev_to_node(dev) == NUMA_NO_NODE)
> mask = cpu_online_mask;
> else
> mask = cpumask_of_node(node);
Doh! I should be cpumask_of_node(dev_to_node(dev)) in the above, of
course. Apologies! Albeit, v3 you sent looks great! Thank you!
Krzysztof
next prev parent reply other threads:[~2021-10-04 19:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-03 9:13 [PATCH v2 1/2] driver core: use NUMA_NO_NODE during device_initialize Max Gurtovoy
2021-10-03 9:13 ` [PATCH v2 2/2] PCI/sysfs: use NUMA_NO_NODE macro Max Gurtovoy
2021-10-04 1:45 ` Krzysztof Wilczyński
2021-10-04 19:07 ` Krzysztof Wilczyński [this message]
2021-10-04 8:12 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVtQ8ummGgG9AOZE@rocinante \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mgurtovoy@nvidia.com \
--cc=oren@nvidia.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox