From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Mianhan Liu <liumh1@shanghaitech.edu.cn>
Cc: Andy Gross <agross@kernel.org>,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next -v2] ./drivers/bluetooth/btqcomsmd.c: remove superfluous header files from btqcomsmd.c
Date: Mon, 4 Oct 2021 12:46:31 -0700 [thread overview]
Message-ID: <YVtaF1YD/T9r8Ucy@ripper> (raw)
In-Reply-To: <20210928200811.22059-1-liumh1@shanghaitech.edu.cn>
On Tue 28 Sep 13:08 PDT 2021, Mianhan Liu wrote:
If you run a "git log --oneline -- drivers/bluetooth/btqcomsmd.c" you
will see that the appropriate prefix would be "Bluetooth: btqcomsmd: "
In other words, a better $subject would be:
[PATCH v2] Bluetooth: btqcomsmd: remove superfluous includes
> btqcomsmd.c hasn't use any macro or function declared in linux/of.h
> and linux/slab.h.
> Thus, these files can be removed from btqcomsmd.c safely without
> affecting the compilation of the ./drivers/bluetooth module
>
> Signed-off-by: Mianhan Liu <liumh1@shanghaitech.edu.cn>
>
> ---
Here is an excellent place to state "Changes since v1" and mention that
you no longer remove btqca.h and you added your S-o-b.
> drivers/bluetooth/btqcomsmd.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/bluetooth/btqcomsmd.c b/drivers/bluetooth/btqcomsmd.c
> index 2acb719e5..e556d96a4 100644
> --- a/drivers/bluetooth/btqcomsmd.c
> +++ b/drivers/bluetooth/btqcomsmd.c
> @@ -5,9 +5,7 @@
> */
>
> #include <linux/module.h>
> -#include <linux/slab.h>
> #include <linux/rpmsg.h>
> -#include <linux/of.h>
>
This looks reasonable.
Regards,
Bjorn
> #include <linux/soc/qcom/wcnss_ctrl.h>
> #include <linux/platform_device.h>
> --
> 2.25.1
>
>
prev parent reply other threads:[~2021-10-04 19:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 20:08 [PATCH -next -v2] ./drivers/bluetooth/btqcomsmd.c: remove superfluous header files from btqcomsmd.c Mianhan Liu
2021-10-04 19:46 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVtaF1YD/T9r8Ucy@ripper \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liumh1@shanghaitech.edu.cn \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox