From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH v1 1/2] serial: 8250_lpss: Extract dw8250_do_set_termios() for common use
Date: Tue, 5 Oct 2021 16:30:45 +0300 [thread overview]
Message-ID: <YVxThfAznxsJVi+n@smile.fi.intel.com> (raw)
In-Reply-To: <YVxKyOODe3ZWmnFZ@kroah.com>
On Tue, Oct 05, 2021 at 02:53:28PM +0200, Greg Kroah-Hartman wrote:
> On Sat, Oct 02, 2021 at 09:51:40PM +0300, Andy Shevchenko wrote:
> > Some of the code currently used in dw8250_set_termios(), byt_set_termios()
> > may be reused by other methods in the future. Extract it to a common helper
> > function.
...
> > - * Premilinary set the uartclk to the new clock rate so the
> > + * Preliminary set the uartclk to the new clock rate so the
>
> Different change, not mentioned in the changelog, please make this a
> separate patch.
Done, v2 has been just sent.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-10-05 13:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-02 18:51 [PATCH v1 1/2] serial: 8250_lpss: Extract dw8250_do_set_termios() for common use Andy Shevchenko
2021-10-02 18:51 ` [PATCH v1 2/2] serial: 8250_lpss: Enable PSE UART Auto Flow Control Andy Shevchenko
2021-10-05 12:53 ` [PATCH v1 1/2] serial: 8250_lpss: Extract dw8250_do_set_termios() for common use Greg Kroah-Hartman
2021-10-05 13:30 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVxThfAznxsJVi+n@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox