From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4900C433EF for ; Tue, 5 Oct 2021 18:11:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 98DCF6115B for ; Tue, 5 Oct 2021 18:11:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235070AbhJESND (ORCPT ); Tue, 5 Oct 2021 14:13:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232861AbhJESM4 (ORCPT ); Tue, 5 Oct 2021 14:12:56 -0400 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00287C06174E for ; Tue, 5 Oct 2021 11:11:05 -0700 (PDT) Received: by mail-wm1-x32e.google.com with SMTP id 63-20020a1c0042000000b0030d60716239so792096wma.4 for ; Tue, 05 Oct 2021 11:11:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=2AmJ6vZK0+G0ZrvpMt62Pt7w266KkCvO13RMS0+WCJU=; b=sVPFNmYDN9rlhW4zEqU1EsMTyqIJmDi/EVk/iWjtAob+VydsVOgdQs82Q2j2aQO4c+ KaVex6CE91yxhnfqLt/+sI9MI3kVk+fb9G/SJ9sTqOyt0m7u77hJPRMlvLlSudw8snnu xoWdKbPaKtdXjauiTd6SbBgtJQpLmfR5Fs0qQlLaHrgUALCbUhMHl7dobqlZgt7dQ8En j2QausMBjQplsY/Mbyi1Gg4/6pOXG2aTBLDI9iI3tV/aBAxZ3hGa3lz60uC6B5FQmGsE qkkgT3X1vYkiL5J4yiGDpqOx26O1ozxmyB/fOTdhE8LRDUpyolsB0piuGehEmXgtrL0J fzpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=2AmJ6vZK0+G0ZrvpMt62Pt7w266KkCvO13RMS0+WCJU=; b=n8bTXAqALNtNH7TPKuOe3HE6CPqqwsahLYoiOqieUQw+sh0R45D1LHKqfwAyaCINgP 31BuXx7tRZNgTfk1xj7QMV7AyDr9bzcSMRmxQMiMJt6t6WnSkUhubaNsFad+DAZpo7R3 bCzViDEGifWrPnjgZokWvwg7rUXzQUy3UyTQwHzOhxbvpdZ9KzZFSAAdesgz4ZIhuX7D v0A1dp74s0e6qdTdm0e5I/t+79JN1dpgbjhIa9qH2HcDO2S9o7ZHM/1QHMTT5WXwLOm+ 9LcG/gDQipVriyAVcrCESlpuDTbiJFczcYISG0Ge5TbWaemj+RUrReShyq4a1ZOcyZLw Nd+w== X-Gm-Message-State: AOAM533r8vIBVk+zrJf54blSvvF5fv0xiVP8EDCSs6/Np/DWZCiqPIPQ 5+CQ5XjfDML65GYb4Jusq4Brnw== X-Google-Smtp-Source: ABdhPJxnZhnLFFMNigyT2txst7cmyByaKs7DgCAzOet4jhC/l/LC7or09f6Q0aiqSjRE4FQA9oEGQQ== X-Received: by 2002:a1c:2904:: with SMTP id p4mr4911298wmp.49.1633457464303; Tue, 05 Oct 2021 11:11:04 -0700 (PDT) Received: from google.com ([95.148.6.175]) by smtp.gmail.com with ESMTPSA id k17sm18491847wrq.7.2021.10.05.11.11.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Oct 2021 11:11:03 -0700 (PDT) Date: Tue, 5 Oct 2021 19:11:02 +0100 From: Lee Jones To: Eric Biggers Cc: Adam Langley , linux-kernel@vger.kernel.org, David Howells , David Woodhouse , keyrings@vger.kernel.org Subject: Re: [PATCH 1/1] sign-file: Use OpenSSL provided define to compile out deprecated APIs Message-ID: References: <20211005161833.1522737-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 05 Oct 2021, Eric Biggers wrote: > On Tue, Oct 05, 2021 at 10:14:58AM -0700, Adam Langley wrote: > > On Tue, Oct 5, 2021 at 10:01 AM Eric Biggers wrote: > > > I ran into these same -Wdeprecated-declarations compiler warnings on another > > > project that uses the ENGINE API to access OpenSSL's support for PKCS#11 tokens. > > > The conclusion was that in OpenSSL 3.0, the new API for PKCS#11 support isn't > > > actually ready yet, so we had to keep using the ENGINE API and just add > > > -Wno-deprecated-declarations to the compiler flags. > > > > > > Your patch just removes support for PKCS#11 in that case, which seems > > > undesirable. (Unless no one is actually using it?) > > > > The patch removes support when OPENSSL_NO_ENGINE is defined, but > > that's not defined by default in OpenSSL 3.0. (Unless something > > changed recently.) > > > > When OPENSSL_NO_ENGINE is defined, ENGINE support is not compiled into > > OpenSSL and the headers don't include the functions: > > https://github.com/openssl/openssl/blob/master/include/openssl/engine.h > > . > > Okay so this patch is actually a build fix for when OpenSSL doesn't include > ENGINE support? Correct. > Currently this patch claims that it's removing the use of a > "deprecated" API, which is something entirely different. I see your point. Happy to rejig the commit message if that would help. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog