From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E53FC433F5 for ; Wed, 20 Oct 2021 11:03:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 753C8613A7 for ; Wed, 20 Oct 2021 11:03:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230168AbhJTLFw (ORCPT ); Wed, 20 Oct 2021 07:05:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:39738 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229910AbhJTLFv (ORCPT ); Wed, 20 Oct 2021 07:05:51 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B2C61613A7; Wed, 20 Oct 2021 11:03:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1634727817; bh=f8Lhl6mKTN67y6PmZ1jxu5lUkqjWdReY/Zc4Ljiid30=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gmEfXtL79/x0McMbGKjYTAyrQtrnRA0L51KbagBD9VaMI0GUfTiyjT8bmVRyN97l8 PPRA0ia9CTILPeI/dKA3q/wDzdOFpwbM04/aHf6lDnzBQDRYM9lxXb5MGjEdCGh35+ +KxIO2Ift22K328aJIu2x9yRbTEvt/aN4p+z7LDQ= Date: Wed, 20 Oct 2021 13:03:34 +0200 From: Greg KH To: Kushal Kothari Cc: fabioaiuto83@gmail.com, marcocesati@gmail.com, dan.carpenter@oracle.com, ross.schm.dev@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com, mike.rapoport@gmail.com, staging@lists.linux.dev Subject: Re: [PATCH v2] staging: rtl8723bs: core: Remove true and false comparison Message-ID: References: <20211020105401.131254-1-kushalkothari285@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211020105401.131254-1-kushalkothari285@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 20, 2021 at 04:24:01PM +0530, Kushal Kothari wrote: > Remove comparison to true and false in if statement. > Issue found with checkpatch.pl. > CHECK: Using comparison to true is error prone > CHECK: Using comparison to false is error prone > > Signed-off-by: Kushal Kothari > --- > > Changes in v2: Remove unnecessary parentheses. > > drivers/staging/rtl8723bs/core/rtw_cmd.c | 50 ++++++++++++------------ > 1 file changed, 25 insertions(+), 25 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c > index efc9b1974e38..3e0b910114da 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c > +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c > @@ -309,8 +309,8 @@ int rtw_cmd_filter(struct cmd_priv *pcmdpriv, struct cmd_obj *cmd_obj) > if (cmd_obj->cmdcode == GEN_CMD_CODE(_SetChannelPlan)) > bAllow = true; > > - if ((pcmdpriv->padapter->hw_init_completed == false && bAllow == false) > - || atomic_read(&(pcmdpriv->cmdthd_running)) == false /* com_thread not running */ > + if ((!pcmdpriv->padapter->hw_init_completed && !bAllow) || > + !atomic_read(&pcmdpriv->cmdthd_running) /* com_thread not running */ > ) > return _FAIL; > > @@ -372,7 +372,7 @@ void rtw_free_cmd_obj(struct cmd_obj *pcmd) > void rtw_stop_cmd_thread(struct adapter *adapter) > { > if (adapter->cmdThread && > - atomic_read(&(adapter->cmdpriv.cmdthd_running)) == true && > + atomic_read(&adapter->cmdpriv.cmdthd_running) && > adapter->cmdpriv.stop_req == 0) { > adapter->cmdpriv.stop_req = 1; > complete(&adapter->cmdpriv.cmd_queue_comp); > @@ -388,7 +388,7 @@ int rtw_cmd_thread(void *context) > u8 (*cmd_hdl)(struct adapter *padapter, u8 *pbuf); > void (*pcmd_callback)(struct adapter *dev, struct cmd_obj *pcmd); > struct adapter *padapter = context; > - struct cmd_priv *pcmdpriv = &(padapter->cmdpriv); > + struct cmd_priv *pcmdpriv = &padapter->cmdpriv; This is not described in your changelog text and has nothing to do with booleans :(