From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Tsuchiya Yuto <kitakar@gmail.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, Andy Shevchenko <andy@kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 1/1] ACPI / PMIC: Add i2c address to intel_pmic_bytcrc driver
Date: Mon, 18 Oct 2021 13:46:42 +0300 [thread overview]
Message-ID: <YW1QkidNKa79MCBb@smile.fi.intel.com> (raw)
In-Reply-To: <3c9d4f9b-26c2-a135-eb2e-67963aa0bc0b@redhat.com>
On Mon, Oct 18, 2021 at 12:38:51PM +0200, Hans de Goede wrote:
> On 10/18/21 12:31, Andy Shevchenko wrote:
> > On Mon, Oct 18, 2021 at 12:16 PM Hans de Goede <hdegoede@redhat.com> wrote:
...
> > Btw, IIRC similar code (i.e. BYT vs CHT by CPU
> > ID) is being used elsewhere. Perhaps we might have some common
> > (library) under arc/x86, PDx86 or so (headers?)?
>
> We already have helpers for this defined in:
>
> sound/soc/intel/common/soc-intel-quirks.h
>
> We could move those to some header under include, maybe:
>
> include/linux/platform_data/x86/atom.h
>
> And add #ifdef-ery there so that things will also build on
> non x86 ?
>
> Then we could do a 2 patch series adding the
> include/linux/platform_data/x86/atom.h
> file + the drivers/mfd/intel_soc_pmic_core.c
> change and Lee can merge both through the MFD tree.
>
> And then we can do further clean-ups of e.g. sound/soc
> on top (we can ask Lee to provide an immutable branch).
>
> How does that sound ?
Sounds like a good plan to me!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-10-18 10:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-17 16:15 [RFC PATCH 0/1] add ccove PMIC i2c address for Microsoft Surface 3 Tsuchiya Yuto
2021-10-17 16:15 ` [RFC PATCH 1/1] ACPI / PMIC: Add i2c address to intel_pmic_bytcrc driver Tsuchiya Yuto
2021-10-17 19:08 ` Andy Shevchenko
2021-10-19 11:45 ` Tsuchiya Yuto
2021-10-18 9:16 ` Hans de Goede
2021-10-18 10:31 ` Andy Shevchenko
2021-10-18 10:38 ` Hans de Goede
2021-10-18 10:46 ` Andy Shevchenko [this message]
2021-10-18 14:01 ` Hans de Goede
2021-10-18 10:50 ` Andy Shevchenko
2021-10-19 11:56 ` Tsuchiya Yuto
2021-10-19 12:05 ` Andy Shevchenko
2021-10-19 12:17 ` Tsuchiya Yuto
2021-10-17 18:53 ` [RFC PATCH 0/1] add ccove PMIC i2c address for Microsoft Surface 3 Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YW1QkidNKa79MCBb@smile.fi.intel.com \
--to=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=hdegoede@redhat.com \
--cc=kitakar@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox